From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 30 Oct 2014 08:52:43 +0000 (+0200)
Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to filter	out	duplicate addresses
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=48f8435d2870ac4cfd931a8ceee36f2c9d9ee6f0;p=notmuch-archives.git

Re: [PATCH v4 5/6] cli: search: Add configurable way to filter	out	duplicate addresses
---

diff --git a/9a/2e7538208477a8b9b966e1cd88172cf86644f5 b/9a/2e7538208477a8b9b966e1cd88172cf86644f5
new file mode 100644
index 000000000..058d74473
--- /dev/null
+++ b/9a/2e7538208477a8b9b966e1cd88172cf86644f5
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1E9EB431FC7
+	for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 01:53:11 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id O8M4nRfoqhYj for <notmuch@notmuchmail.org>;
+	Thu, 30 Oct 2014 01:53:03 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 68B5C431FB6
+	for <notmuch@notmuchmail.org>; Thu, 30 Oct 2014 01:53:03 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id 548E4100051;
+	Thu, 30 Oct 2014 10:52:43 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>,
+	Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
+Subject: Re: [PATCH v4 5/6] cli: search: Add configurable way to
+	filter	out	duplicate addresses
+In-Reply-To: <87egtqug4t.fsf@qmul.ac.uk>
+References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz>
+	<1414421455-3037-6-git-send-email-sojkam1@fel.cvut.cz>
+	<87egtqug4t.fsf@qmul.ac.uk>
+User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 30 Oct 2014 10:52:43 +0200
+Message-ID: <m2zjceueg4.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 30 Oct 2014 08:53:11 -0000
+
+On Thu, Oct 30 2014, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> On Mon, 27 Oct 2014, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
+>> This adds an algorithm to filter out duplicate addresses from address
+>> outputs (sender, receivers). The algorithm can be configured with
+>> --filter-by command line option.
+>>
+>> The code here is an extended version of a patch from Jani Nikula.
+>
+> Hi
+>
+> As this is getting into the more controversial bike shedding region I
+> wonder if it would be worth splitting this into 2 patches: the first
+> could do the default dedupe based on name/address and the second could
+> do add the filter-by options. 
+>
+> I think the default deduping is obviously worth doing but I am not sure
+> about the rest. In any case I think the default deduping could go in
+> pre-freeze but I would recommend the rest is left until after.
+
+I can agree with that, but there is one hard thing to resolve: 
+"naming things"(*)
+
+(*) http://martinfowler.com/bliki/TwoHardThings.html
+
+With all rest ignored (sorry no time to work on this in more detail now),
+this default deduping could be done with single argument '--unique'...
+
+Tomi
+