From: Ben Walton <bdwalton@gmail.com> Date: Sat, 9 Feb 2013 21:46:58 +0000 (+0000) Subject: cvsimport: format commit timestamp ourselves without using strftime X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=48c916285753907b71a0ef663576f01ee260095c;p=git.git cvsimport: format commit timestamp ourselves without using strftime Some implementations of strftime(3) lack support for "%z". Also there is no need for %s in git-cvsimport as the supplied time is already in seconds since the epoch. For %z, use the function get_tz_offset provided by Git.pm instead. Signed-off-by: Ben Walton <bdwalton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com> --- diff --git a/git-cvsimport.perl b/git-cvsimport.perl index 0a31ebd82..344f1206d 100755 --- a/git-cvsimport.perl +++ b/git-cvsimport.perl @@ -26,6 +26,7 @@ use IO::Socket; use IO::Pipe; use POSIX qw(strftime tzset dup2 ENOENT); use IPC::Open2; +use Git qw(get_tz_offset); $SIG{'PIPE'}="IGNORE"; set_timezone('UTC'); @@ -864,7 +865,9 @@ sub commit { } set_timezone($author_tz); - my $commit_date = strftime("%s %z", localtime($date)); + # $date is in the seconds since epoch format + my $tz_offset = get_tz_offset($date); + my $commit_date = "$date $tz_offset"; set_timezone('UTC'); $ENV{GIT_AUTHOR_NAME} = $author_name; $ENV{GIT_AUTHOR_EMAIL} = $author_email;