From: Gerrit Pape Date: Mon, 26 Apr 2010 09:50:39 +0000 (+0200) Subject: git-submodule.sh: properly initialize shell variables X-Git-Tag: v1.7.2-rc0~43^2~3 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=48bb30331dc1139a7279d1665cfc76f14b5d0e67;p=git.git git-submodule.sh: properly initialize shell variables git-submodule inherits variables from the environment it is started in, expects the internal variables init= and recursive= to have an empty value, but doesn't initialize them appropriately. Thanks to the selftests, this can be reproduced through init=1 make test recursive=1 make test With this commit the variables are initialized, and the selftests succeed even if these variables have some values in the environment. The bug was discovered through the Debian autobuilders http://bugs.debian.org/569594 Signed-off-by: Gerrit Pape Signed-off-by: Junio C Hamano --- diff --git a/git-submodule.sh b/git-submodule.sh index e2082fd14..d3c583d01 100755 --- a/git-submodule.sh +++ b/git-submodule.sh @@ -21,6 +21,8 @@ command= branch= reference= cached= +recursive= +init= files= nofetch= update=