From: Peter Wang Date: Sun, 23 Jun 2013 03:57:27 +0000 (+1000) Subject: Re: [PATCH v6 03/12] cli: add insert command X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=48b7972022867818014fcda6a7169c1070bd751e;p=notmuch-archives.git Re: [PATCH v6 03/12] cli: add insert command --- diff --git a/14/20924e9902e6d19787bf4425f205bbb11aa917 b/14/20924e9902e6d19787bf4425f205bbb11aa917 new file mode 100644 index 000000000..afe5a97bf --- /dev/null +++ b/14/20924e9902e6d19787bf4425f205bbb11aa917 @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E2164431FB6 + for ; Sat, 22 Jun 2013 20:57:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id yHIL8SaI2mjp for ; + Sat, 22 Jun 2013 20:57:23 -0700 (PDT) +Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com + [209.85.220.50]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 4CE82431FAE + for ; Sat, 22 Jun 2013 20:57:23 -0700 (PDT) +Received: by mail-pa0-f50.google.com with SMTP id fb1so9439906pad.23 + for ; Sat, 22 Jun 2013 20:57:22 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=date:message-id:from:to:cc:subject:in-reply-to:references + :mime-version:content-type:content-disposition + :content-transfer-encoding; + bh=W3GTm0BNPyg1hY77/NnMyccF7BwKsmisV6Lr7YJEVcU=; + b=NnBNCof6rKbzV8IQgzVew4yttyFx/MfjlTym72QQ81Z7Tv6fQPGjul0y9AWbRR+AYC + bZ3kFha/3nY3IELPW5YpbptJ6wvMtJTxJgo0iwg42pvMCxZ7VmKs+XhBQc9qLzbUM7Io + 1bNJPuHjaEjlJUxTmqoM3OWQ0E/FP+kqzdiRfSH61Iqa9IdPNiOtkI7okQonyEGdUVJL + Uou14+h6JfAHar9D4qkRh2jd0TOUc4ydJop5s9uSQAUVAALnRjvxpIaYJuqVJpaoEpoB + Roou8T6+Tf7tG3HsZH74z/mhMbpV6nISBO1rSplHkpujThQU5i/8a8dvQzJWF8/wesFv + vWcw== +X-Received: by 10.66.232.9 with SMTP id tk9mr22366349pac.20.1371959841473; + Sat, 22 Jun 2013 20:57:21 -0700 (PDT) +Received: from localhost (215.42.233.220.static.exetel.com.au. + [220.233.42.215]) by mx.google.com with ESMTPSA id + dj5sm11757558pbc.25.2013.06.22.20.57.18 for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sat, 22 Jun 2013 20:57:20 -0700 (PDT) +Date: Sun, 23 Jun 2013 13:57:27 +1000 +Message-ID: <20130623135727.GA6190@hili.localdomain> +From: Peter Wang +To: Mark Walters +Subject: Re: [PATCH v6 03/12] cli: add insert command +In-Reply-To: <87hagqvb4n.fsf@qmul.ac.uk> +References: <1371880008-18312-1-git-send-email-novalazy@gmail.com> + <1371880008-18312-4-git-send-email-novalazy@gmail.com> + <87hagqvb4n.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 23 Jun 2013 03:57:31 -0000 + +On Sat, 22 Jun 2013 08:48:56 +0100, Mark Walters wrote: +> +> I think I would like the option to have the command fail if it doesn't +> get added to the database. If, for example, the command is used to +> postpone a message it may be very difficult/impossible to find it +> without the postponed tag that I asked for. +> +> Could we have a --fail-on-index-fail cli option which says which +> behaviour we want? It is a little ugly but I think different users will +> want different behaviour and there is a risk of dataloss in either case. + +I would like that option, too (not sure about the name). It can be +added after at least the first few patches in the series are pushed. + +Peter