From: Gerrit Pape <pape@smarden.org>
Date: Mon, 11 Feb 2008 10:57:40 +0000 (+0000)
Subject: [PATCH] gitk: properly deal with tag names containing / (slash)
X-Git-Tag: v1.5.5-rc0~13^2~11
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=48750d6a84a7fc08dcd7cb4533c280c00106f9b6;p=git.git

[PATCH] gitk: properly deal with tag names containing / (slash)

When creating a tag through gitk, and the tag name includes a slash (or
slashes), gitk errors out in a popup window.  This patch makes gitk use
'git tag' to create the tag instead of modifying files in refs/tags/,
which fixes the issue; if 'git tag' throws an error, gitk pops up with
the error message.

The problem was reported by Frédéric Brière through
 http://bugs.debian.org/464104

Signed-off-by: Gerrit Pape <pape@smarden.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/gitk b/gitk
index dab9df067..80544bfc5 100755
--- a/gitk
+++ b/gitk
@@ -6149,11 +6149,7 @@ proc domktag {} {
 	return
     }
     if {[catch {
-	set dir [gitdir]
-	set fname [file join $dir "refs/tags" $tag]
-	set f [open $fname w]
-	puts $f $id
-	close $f
+	exec git tag $tag $id
     } err]} {
 	error_popup "[mc "Error creating tag:"] $err"
 	return