From: Mark Walters Date: Sun, 27 Jul 2014 09:33:02 +0000 (+0100) Subject: Re: [PATCH 04/14] new: Don't report version after upgrade X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4791d0952cae52a484321ce8fc047672e8ab49dd;p=notmuch-archives.git Re: [PATCH 04/14] new: Don't report version after upgrade --- diff --git a/5f/c6835da19943792507029c93b11123d4276ac7 b/5f/c6835da19943792507029c93b11123d4276ac7 new file mode 100644 index 000000000..b50b1026b --- /dev/null +++ b/5f/c6835da19943792507029c93b11123d4276ac7 @@ -0,0 +1,136 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 623B9431FBC + for ; Sun, 27 Jul 2014 02:33:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5VfnxNiHeJML for ; + Sun, 27 Jul 2014 02:33:15 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id CC023431FB6 + for ; Sun, 27 Jul 2014 02:33:14 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1XBKpG-0005Xp-DE; Sun, 27 Jul 2014 10:33:09 +0100 +Received: from 94.196.249.126.threembb.co.uk ([94.196.249.126] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1XBKpF-0002Rm-M5; Sun, 27 Jul 2014 10:33:06 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 04/14] new: Don't report version after upgrade +In-Reply-To: <1406433173-19169-5-git-send-email-amdragon@mit.edu> +References: <1406433173-19169-1-git-send-email-amdragon@mit.edu> + <1406433173-19169-5-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 27 Jul 2014 10:33:02 +0100 +Message-ID: <87y4vfywmp.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 94.196.249.126 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: ce1ec861b7e9488729ea4d284c3c3b54 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 27 Jul 2014 09:33:22 -0000 + +On Sun, 27 Jul 2014, Austin Clements wrote: +> The version number has always been pretty meaningless to the user and +> it's about to become even more meaningless with the introduction of +> "features". Hopefully, the database will remain on version 3 for some +> time to come; however, the introduction of new features over time in +> version 3 will necessitate upgrades within version 3. It would be +> confusing if we always tell the user they've been "upgraded to version +> 3". If the user wants to know what's new, they should read the news. + +Two thoughts on this: + +first, we could print the names of the new features here to make it +easier for the user to find them in NEWS. + +Secondly, would it be worth having something like notmuch +--database-version or similar which prints the features? If I understand +the series then notmuch clients don't necessarily need to upgrade the +database unless they want the new features. This means that knowing what +version they are running might not tell us which features they have +enabled (which could make debugging difficult) + +Best wishes + +Mark + +> --- +> notmuch-new.c | 3 +-- +> test/T530-upgrade.sh | 2 +- +> 2 files changed, 2 insertions(+), 3 deletions(-) +> +> diff --git a/notmuch-new.c b/notmuch-new.c +> index d269c7c..b7590a8 100644 +> --- a/notmuch-new.c +> +++ b/notmuch-new.c +> @@ -1023,8 +1023,7 @@ notmuch_new_command (notmuch_config_t *config, int argc, char *argv[]) +> add_files_state.verbosity >= VERBOSITY_NORMAL ? upgrade_print_progress : NULL, +> &add_files_state); +> if (add_files_state.verbosity >= VERBOSITY_NORMAL) +> - printf ("Your notmuch database has now been upgraded to database format version %u.\n", +> - notmuch_database_get_version (notmuch)); +> + printf ("Your notmuch database has now been upgraded.\n"); +> } +> +> add_files_state.total_files = 0; +> diff --git a/test/T530-upgrade.sh b/test/T530-upgrade.sh +> index 7d5d5aa..c4c4ac8 100755 +> --- a/test/T530-upgrade.sh +> +++ b/test/T530-upgrade.sh +> @@ -33,7 +33,7 @@ test_expect_equal "$output" "\ +> Welcome to a new version of notmuch! Your database will now be upgraded. +> This process is safe to interrupt. +> Backing up tags to FILENAME +> -Your notmuch database has now been upgraded to database format version 2. +> +Your notmuch database has now been upgraded. +> No new mail." +> +> test_begin_subtest "tag backup matches pre-upgrade dump" +> -- +> 2.0.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch