From: Pat Thoyts <patthoyts@users.sourceforge.net>
Date: Wed, 15 Apr 2009 16:14:03 +0000 (+0100)
Subject: gitk: Avoid crash if closed while reading references
X-Git-Tag: v1.6.3-rc4~4^2~2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=478afad697e58433f34d69b5fe08511405f23506;p=git.git

gitk: Avoid crash if closed while reading references

As recorded in msysGit issue 125, if the user closes gitk while it
reports itself as still reading references then Tk will crash in the
geometry management code.  This has been fixed for Tk 8.5.7 and above.
This patch avoids the problem by flushing outstanding geometry events
before calling the readrefs procedure.

See also http://code.google.com/p/msysgit/issues/detail?id=125

Signed-off-by: Pat Thoyts <patthoyts@users.sourceforge.net>
Signed-off-by: Paul Mackerras <paulus@samba.org>
---

diff --git a/gitk b/gitk
index 488286f6a..dca1741c7 100755
--- a/gitk
+++ b/gitk
@@ -11128,6 +11128,7 @@ catch {
 # wait for the window to become visible
 tkwait visibility .
 wm title . "[file tail $argv0]: [file tail [pwd]]"
+update
 readrefs
 
 if {$cmdline_files ne {} || $revtreeargs ne {} || $revtreeargscmd ne {}} {