From: David Edmondson Date: Mon, 7 Mar 2016 18:49:23 +0000 (+0000) Subject: Re: [PATCH v6 4/6] emacs/mua: Generate improved cited text for replies X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4700cc567e7e26face7151923049802d69659875;p=notmuch-archives.git Re: [PATCH v6 4/6] emacs/mua: Generate improved cited text for replies --- diff --git a/9c/ed6c870c45d5fa98b15e6a3aa71f01fab4679d b/9c/ed6c870c45d5fa98b15e6a3aa71f01fab4679d new file mode 100644 index 000000000..43327c286 --- /dev/null +++ b/9c/ed6c870c45d5fa98b15e6a3aa71f01fab4679d @@ -0,0 +1,119 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 0EA8E6DE1668 + for ; Mon, 7 Mar 2016 10:49:29 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.139 +X-Spam-Level: +X-Spam-Status: No, score=-0.139 tagged_above=-999 required=5 + tests=[AWL=-0.072, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id zEsHMWRWqAWG for ; + Mon, 7 Mar 2016 10:49:27 -0800 (PST) +Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com + [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 040D46DE1715 for + ; Mon, 7 Mar 2016 10:49:27 -0800 (PST) +Received: by mail-wm0-f65.google.com with SMTP id p65so12374967wmp.1 + for ; Mon, 07 Mar 2016 10:49:26 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version + :content-transfer-encoding; + bh=0HnrzD//wyO9GYoPtsuJwNoXJ9Z5E3kFyF4n7kuOKLo=; + b=OFkDESlY1xT+vGdGcUZsCt2k+SUoYM3uE6qF1MCjduFdGQbDEqs9M/BJ7rwG9nyHtX + /4EADaYln6luaD0jsxu9UOmyde6zof+sqYjXQE2taBv4I50r/DW4+Ygnh85xgA1/VZyp + 2/MGFWoiVhDM6ptwmCV/GilMngmrgVDuURkJ04YzI7/Srx3C7la3P3o6T3f1NCCawth6 + XdubUuct4YSN0wQ5KUsX5Fp3rFG30tTZyF0HyP8kWAe9CqUwSQJj3wNJYwGqUuqU8EEU + 5HFAzsMcNqoRqdi5m7SsRz7hLdrq0TQb9ULC9ZI4Ok5MvSDyxvc39ayZXm7xT3Sxl4aG + B5Kg== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version:content-transfer-encoding; + bh=0HnrzD//wyO9GYoPtsuJwNoXJ9Z5E3kFyF4n7kuOKLo=; + b=GInrLKsVORfMilb3jy/I+fH+PdP7ZFY9Gmmqj+MQo2qWME6cKv1WqAtsv4Zdqh2GYq + dx5sAAEwZeCtWlhAUgCFhLlioLqfXutuafxJDTc7VT1GW/i9YowAH2LkFV4cA7WqToLx + EuaxsnkbftyKA/2/IDdvPyWcZcqodl0PBrYKOmNnNZkvWM54rC+ShLi9wsfrdp4FN4In + F6Y/FB08EUCGH+fFXQMqoM28Ib/hJ87/tXQoq6zrhdbF3BkeE5z0+ERjmO8iRVKKdivy + 09k5Xsj9lo5hWspo0zYRfGKk3F8G2VEQN8B5jWz2HKWCGmxg4jL0pHpL4CD6YOofgsml + MxNg== +X-Gm-Message-State: + AD7BkJIEfWNY++cAs3GWzh+h3OGuE9Ck0ZwJDkN6FFEpKILugigi2c3365b265STH1Fq9g== +X-Received: by 10.194.184.234 with SMTP id ex10mr23269073wjc.8.1457376565749; + Mon, 07 Mar 2016 10:49:25 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id da6sm19305826wjb.24.2016.03.07.10.49.24 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 07 Mar 2016 10:49:24 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 297e364e; + Mon, 7 Mar 2016 18:49:23 +0000 (UTC) +To: Jani Nikula , Mark Walters , + notmuch@notmuchmail.org +Subject: Re: [PATCH v6 4/6] emacs/mua: Generate improved cited text for + replies +In-Reply-To: <87mvqa5eo1.fsf@nikula.org> +References: <1455992680-24978-1-git-send-email-markwalters1009@gmail.com> + <1455992680-24978-5-git-send-email-markwalters1009@gmail.com> + <87vb4y5g6s.fsf@nikula.org> + <87mvqa5eo1.fsf@nikula.org> +From: David Edmondson +Date: Mon, 07 Mar 2016 18:49:23 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 07 Mar 2016 18:49:29 -0000 + +On Mon, Mar 07 2016, Jani Nikula wrote: +> On Mon, 07 Mar 2016, David Edmondson wrote: +>> [ text/plain ] +>> On Mon, Mar 07 2016, Jani Nikula wrote: +>>> For a message with mime structure: +>>> +>>> =E2=94=94=E2=94=AC=E2=95=B4multipart/mixed 120338 bytes +>>> =E2=94=9C=E2=94=80=E2=95=B4text/html 59234 bytes +>>> =E2=94=94=E2=94=80=E2=95=B4application/octet-stream attachment [filena= +me.html] 59234 bytes +>> +>> How is this displayed when viewing the message (as opposed to replying)? +> +> Both parts are displayed roughly similarly as html, with the error +> message in between. The latter part has some images the former part +> doesn't have. +> +>> How do you think that it is intended to be displayed? Are they two +>> sub-parts of the multipart/mixed intended to be alternatives? (It +>> doesn't seem so, as you mention later that they have the same content.) +> +> I think they're intended to be alternatives, but there's really no way +> to deduce that. +> +> IMO it's sufficient to try get rid of the error message in show and +> reply. + +Ah, I didn't realise that the error was shown when you view the message +normally. Well, in that case, the reply changes are working as designed +in this respect ;-) + +(But it's obviously still a bug that you get the message at all.)