From: David Bremner Date: Thu, 23 May 2013 11:46:07 +0000 (+2100) Subject: Re: [PATCH] emacs: Compute build dependencies to fix byte compile issues X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=46cf72242e9d1f971354f2b1da9ab5c10e0eef1b;p=notmuch-archives.git Re: [PATCH] emacs: Compute build dependencies to fix byte compile issues --- diff --git a/f2/1d745b0498a2dfa38e9e9ef1352464bf566e47 b/f2/1d745b0498a2dfa38e9e9ef1352464bf566e47 new file mode 100644 index 000000000..26d759b31 --- /dev/null +++ b/f2/1d745b0498a2dfa38e9e9ef1352464bf566e47 @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 36F68431FD2 + for ; Thu, 23 May 2013 04:46:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9FnjnmAB8Rd3 for ; + Thu, 23 May 2013 04:46:15 -0700 (PDT) +Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 637C5431FBF + for ; Thu, 23 May 2013 04:46:15 -0700 (PDT) +Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) + by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id r4NBkE8Q004076; + Thu, 23 May 2013 08:46:14 -0300 +Received: from fctnnbsc30w-156034082078.dhcp-dynamic.fibreop.nb.bellaliant.net + ([156.34.82.78] helo=zancas.localnet) + by tesseract.cs.unb.ca with esmtpsa + (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) + (envelope-from ) + id 1UfTyH-0003p6-NF; Thu, 23 May 2013 08:46:13 -0300 +Received: from bremner by zancas.localnet with local (Exim 4.80) + (envelope-from ) + id 1UfTyC-0008NC-3q; Thu, 23 May 2013 08:46:08 -0300 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Compute build dependencies to fix byte compile + issues +In-Reply-To: <1368821611-24110-1-git-send-email-amdragon@mit.edu> +References: <1368821611-24110-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+114~g3b2344e (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Thu, 23 May 2013 08:46:07 -0300 +Message-ID: <871u8xq5q8.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-Spam_bar: - +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 23 May 2013 11:46:22 -0000 + +Austin Clements writes: + +> Previously, we simply byte compiled each Elisp source file +> independently. This is actually the wrong thing to do and can lead to +> issues with macros and performance issues with substitutions because +> 1) when the byte compiler encounters a (require 'x) form, it will load +> x.elc in preference to x.el, even if x.el is newer, and as a result +> may load old macro and substitution definitions and 2) if we update a +> macro or substitution definition in one file, we currently won't +> re-compile other files that depend on the file containing the +> definition. + +Pushed, + +d