From: Tomi Ollila Date: Sun, 5 May 2013 09:58:54 +0000 (+0300) Subject: Re: [PATCH 0/2] Enhancements to notmuch-hello search history X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4679efc711c38cd4903167fef7fdcc687c6fd0e1;p=notmuch-archives.git Re: [PATCH 0/2] Enhancements to notmuch-hello search history --- diff --git a/b1/6aa0e1adab2adda4dc20debad670f7d71cb77c b/b1/6aa0e1adab2adda4dc20debad670f7d71cb77c new file mode 100644 index 000000000..af4b8e258 --- /dev/null +++ b/b1/6aa0e1adab2adda4dc20debad670f7d71cb77c @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id B2201431FAF + for ; Sun, 5 May 2013 02:59:00 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id WJHAzXpA9uC5 for ; + Sun, 5 May 2013 02:58:56 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 81A67431FAE + for ; Sun, 5 May 2013 02:58:56 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 363B6100033; + Sun, 5 May 2013 12:58:55 +0300 (EEST) +From: Tomi Ollila +To: Servilio Afre Puentes , Jani Nikula , + notmuch +Subject: Re: [PATCH 0/2] Enhancements to notmuch-hello search history +In-Reply-To: <87ppx6lo6g.fsf@goose.CSU.McMaster.CA> +References: <87y5bwkml2.fsf@goose.CSU.McMaster.CA> <874nejrupr.fsf@nikula.org> + <87ppx6lo6g.fsf@goose.CSU.McMaster.CA> +User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 May 2013 09:59:00 -0000 + +On Sat, May 04 2013, Servilio Afre Puentes wrote: + +> Jani Nikula writes: +> +>> On Fri, 03 May 2013, Servilio Afre Puentes wrote: +>>> Two patches that enhance the notmuch-hello search history UI. Though +>>> minor I find them very helpful. +>> +>> Both seem to work as advertised; I did not look at the code much. A +>> minor bikeshed is that I think y-or-n-p would suffice in patch 1/2. +> +> I know, but as it clears the whole history I decided to go with a +> confirmation that required more attention to diminish the chance of +> accident, and the action is taken not so oftenly (at least for me, and +> my guess is that it is the same for most) so it stills balances out +> positively in the usability. + +I tested the patch and it works as advertised. + +I agree with Jani that y-or-n-p would suffice for clearing all +recent searches (but yes-or-no-p is not so bad as I originally thought +as C-g can be used to stop processing (typoing 'no' is too easy ;/). + +If we could use "undo" feature to restore last clear/del then I'd agree +100% with Mark (i.e. no y-or-n-p for [del]). + +In any case fix at least the style issue Mark mentioned -- any of the +yes/no queries will eventually be fine with me (as I don't know without +experience what would be the best (for me) after all). + +> Servilio + +Tomi