From: Mark Walters Date: Sun, 2 Jun 2013 12:01:12 +0000 (+0100) Subject: Re: [PATCH] contrib: pick: use the sexp parser X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=44ef164ad290c3aa78080cfa3e0364bd98932ca8;p=notmuch-archives.git Re: [PATCH] contrib: pick: use the sexp parser --- diff --git a/9d/1bd50ae0e954e9ef041c8a61d1db1c7cfaaf43 b/9d/1bd50ae0e954e9ef041c8a61d1db1c7cfaaf43 new file mode 100644 index 000000000..5a751f1bd --- /dev/null +++ b/9d/1bd50ae0e954e9ef041c8a61d1db1c7cfaaf43 @@ -0,0 +1,124 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id D95DD429E2F + for ; Sun, 2 Jun 2013 05:01:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id fnVLm9Tdlvlr for ; + Sun, 2 Jun 2013 05:01:23 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id AE19D431E64 + for ; Sun, 2 Jun 2013 05:01:22 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Uj6yK-0007SV-6W; Sun, 02 Jun 2013 13:01:18 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Uj6yJ-0003rX-Vy; Sun, 02 Jun 2013 13:01:16 +0100 +From: Mark Walters +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] contrib: pick: use the sexp parser +In-Reply-To: +References: <1370113483-10081-1-git-send-email-markwalters1009@gmail.com> + +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Sun, 02 Jun 2013 13:01:12 +0100 +Message-ID: <87sj10g1rr.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 4930dc4cc7c3fcae0bcc227ef1a65ba0 (of first 20000 bytes) +X-SpamAssassin-Score: 0.5 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.5 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * -0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 02 Jun 2013 12:01:32 -0000 + + +Tomi Ollila writes: + +> These trivial changes look good -- is sexp already supported in show ? + +At the moment sexp is not supported in show (despite that using +synchronous command so it is much easier). I posted a (not good) at +id:1354975891-24663-1-git-send-email-markwalters1009@gmail.com and in +Austin's reply he suggested a much better way of doing is. But I never posted a +corrected version (perhaps I was waiting for the error handling stuff to +clear?). + +Best wishes + +Mark + +> +> Tomi +> +>> +>> contrib/notmuch-pick/notmuch-pick.el | 5 ++--- +>> 1 files changed, 2 insertions(+), 3 deletions(-) +>> +>> diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el +>> index 128fabf..33905d6 100644 +>> --- a/contrib/notmuch-pick/notmuch-pick.el +>> +++ b/contrib/notmuch-pick/notmuch-pick.el +>> @@ -773,8 +773,7 @@ Complete list of currently available key bindings: +>> (save-excursion +>> (goto-char (point-max)) +>> (insert string)) +>> - (notmuch-json-parse-partial-list 'notmuch-pick-insert-forest-thread +>> - 'notmuch-pick-show-error +>> + (notmuch-sexp-parse-partial-list 'notmuch-pick-insert-forest-thread +>> results-buf))))) +>> +>> (defun notmuch-pick-worker (basic-query &optional query-context target buffer) +>> @@ -796,7 +795,7 @@ Complete list of currently available key bindings: +>> (if notmuch-pick-asynchronous-parser +>> (let ((proc (start-process +>> "notmuch-pick" buffer +>> - notmuch-command "show" "--body=false" "--format=json" +>> + notmuch-command "show" "--body=false" "--format=sexp" +>> message-arg search-args)) +>> ;; Use a scratch buffer to accumulate partial output. +>> ;; This buffer will be killed by the sentinel, which +>> -- +>> 1.7.9.1 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch