From: Austin Clements Date: Wed, 11 Sep 2013 18:37:49 +0000 (+2000) Subject: Re: [PATCH v2 1/2] test: add known broken tests for known broken RFC 2047 encodings X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4452875653eb31a74ee119f01fe06a666b490188;p=notmuch-archives.git Re: [PATCH v2 1/2] test: add known broken tests for known broken RFC 2047 encodings --- diff --git a/c1/8527d62480f52dce8595d0ee37eb83caa6b6ce b/c1/8527d62480f52dce8595d0ee37eb83caa6b6ce new file mode 100644 index 000000000..d9bbb137f --- /dev/null +++ b/c1/8527d62480f52dce8595d0ee37eb83caa6b6ce @@ -0,0 +1,116 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 394CF431FB6 + for ; Wed, 11 Sep 2013 11:38:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id IfTaRLFTmifa for ; + Wed, 11 Sep 2013 11:37:55 -0700 (PDT) +Received: from dmz-mailsec-scanner-1.mit.edu (dmz-mailsec-scanner-1.mit.edu + [18.9.25.12]) + by olra.theworths.org (Postfix) with ESMTP id 1E37C431FAF + for ; Wed, 11 Sep 2013 11:37:55 -0700 (PDT) +X-AuditID: 1209190c-b7fac8e000006335-c3-5230b882e49e +Received: from mailhub-auth-2.mit.edu ( [18.7.62.36]) + by dmz-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP + id 1B.73.25397.288B0325; Wed, 11 Sep 2013 14:37:54 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r8BIbqTN005308; + Wed, 11 Sep 2013 14:37:53 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r8BIbo37017419 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Wed, 11 Sep 2013 14:37:51 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1VJpIT-0006X4-TO; Wed, 11 Sep 2013 14:37:49 -0400 +Date: Wed, 11 Sep 2013 14:37:49 -0400 +From: Austin Clements +To: Jani Nikula +Subject: Re: [PATCH v2 1/2] test: add known broken tests for known broken RFC + 2047 encodings +Message-ID: <20130911183749.GJ1426@mit.edu> +References: <8738pcjet4.fsf@awakening.csail.mit.edu> + <1378921003-14639-1-git-send-email-jani@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +In-Reply-To: <1378921003-14639-1-git-send-email-jani@nikula.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFlrIKsWRmVeSWpSXmKPExsUixG6notu0wyDIYMIEOYvW7s9MFk3TnS2u + 35zJ7MDscba7ndXj1v3X7B7PVt1iDmCO4rJJSc3JLEst0rdL4MpoO7GIuWAWf8WLh7tYGxhb + eLsYOTkkBEwkJnf8Z4awxSQu3FvPBmILCexjlFhxNa+LkQvI3sgo8WXWCSaIxGkmiScb+SAS + SxglLl9oYOli5OBgEVCVmLHaFKSGTUBDYtv+5YwgtoiAosTmk/vBbGYBD4n7c3rA5ggLxEnM + PLCDFaSVV0BbYt70YIjxWRIN/7exgti8AoISJ2c+YYFoVZf4M+8SM0g5s4C0xPJ/HBBheYnm + rbPBzucUcJC4sXop2HRRARWJKSe3sU1gFJ6FZNIsJJNmIUyahWTSAkaWVYyyKblVurmJmTnF + qcm6xcmJeXmpRbqGermZJXqpKaWbGEExwSnJs4PxzUGlQ4wCHIxKPLwdswyChFgTy4orcw8x + SnIwKYnyRm8HCvEl5adUZiQWZ8QXleakFh9ilOBgVhLhbZ8AlONNSaysSi3Kh0lJc7AoifOu + c9IPEhJITyxJzU5NLUgtgsnKcHAoSfAmggwVLEpNT61Iy8wpQUgzcXCCDOcBGs4LUsNbXJCY + W5yZDpE/xagoJc5bAJIQAElklObB9cJS1itGcaBXhHk7QKp4gOkOrvsV0GAmoMHfffVBBpck + IqSkGhgdMoKkZt19McPfX13z0Z7FmnJJerV2fz3S/S4/F2HRPTtBd0fRK7nMHeWlTRN6Uo7I + RcQ8XHV41tKYgHkf5m43uz3329FLz7ZtZvZXDvw18YfKrW2t9gb3ZzhYiB9knvj66J//V3dz + r7rc0DH3QYqxysofjCfWpCrtW2vsxaS6ZomW/oIpvwXXK7EUZyQaajEXFScCAOgaHIw0AwAA +Cc: notmuch@notmuchmail.org, Daniel Kahn Gillmor +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 11 Sep 2013 18:38:03 -0000 + +v2 LGTM. + +Quoth Jani Nikula on Sep 11 at 8:36 pm: +> Some common broken RFC 2047 encodings that we currently let gmime +> parse strictly. We could tell gmime to be forgiving in what it accepts +> as RFC 2047 encoding, making these tests pass. +> --- +> test/encoding | 18 ++++++++++++++++++ +> 1 file changed, 18 insertions(+) +> +> diff --git a/test/encoding b/test/encoding +> index 2e1326e..7372b6b 100755 +> --- a/test/encoding +> +++ b/test/encoding +> @@ -29,4 +29,22 @@ add_message '[content-type]="text/plain; charset=iso-8859-2"' \ +> output=$(notmuch search tučňáččí 2>&1 | notmuch_show_sanitize) +> test_expect_equal "$output" "thread:0000000000000002 2001-01-05 [1/1] Notmuch Test Suite; ISO-8859-2 encoded message (inbox unread)" +> +> +test_begin_subtest "RFC 2047 encoded word with spaces" +> +test_subtest_known_broken +> +add_message '[subject]="=?utf-8?q?encoded word with spaces?="' +> +output=$(notmuch search id:${gen_msg_id} 2>&1 | notmuch_show_sanitize) +> +test_expect_equal "$output" "thread:0000000000000003 2001-01-05 [1/1] Notmuch Test Suite; encoded word with spaces (inbox unread)" +> + +> +test_begin_subtest "RFC 2047 encoded words back to back" +> +test_subtest_known_broken +> +add_message '[subject]="=?utf-8?q?encoded-words-back?==?utf-8?q?to-back?="' +> +output=$(notmuch search id:${gen_msg_id} 2>&1 | notmuch_show_sanitize) +> +test_expect_equal "$output" "thread:0000000000000004 2001-01-05 [1/1] Notmuch Test Suite; encoded-words-backto-back (inbox unread)" +> + +> +test_begin_subtest "RFC 2047 encoded words without space before or after" +> +test_subtest_known_broken +> +add_message '[subject]="=?utf-8?q?encoded?=word without=?utf-8?q?space?=" ' +> +output=$(notmuch search id:${gen_msg_id} 2>&1 | notmuch_show_sanitize) +> +test_expect_equal "$output" "thread:0000000000000005 2001-01-05 [1/1] Notmuch Test Suite; encodedword withoutspace (inbox unread)" +> + +> test_done