From: David Bremner <david@tethera.net>
Date: Sun, 5 Oct 2014 07:45:42 +0000 (+0200)
Subject: Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4239b56a5005feec49d99dcc574d4621b8692e38;p=notmuch-archives.git

Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message
---

diff --git a/fb/7544106aa406c55f699dbb99f21aa3360dd559 b/fb/7544106aa406c55f699dbb99f21aa3360dd559
new file mode 100644
index 000000000..b6c4869f7
--- /dev/null
+++ b/fb/7544106aa406c55f699dbb99f21aa3360dd559
@@ -0,0 +1,59 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 125AB431FC7
+	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 00:45:57 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id 8QyXQC8wNJ2Z for <notmuch@notmuchmail.org>;
+	Sun,  5 Oct 2014 00:45:53 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id 4DA78431FB6
+	for <notmuch@notmuchmail.org>; Sun,  5 Oct 2014 00:45:53 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1XagVs-0007XA-Eq; Sun, 05 Oct 2014 04:45:52 -0300
+Received: (nullmailer pid 30613 invoked by uid 1000); Sun, 05 Oct 2014
+	07:45:42 -0000
+From: David Bremner <david@tethera.net>
+To: Austin Clements <aclements@csail.mit.edu>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 02/11] lib: Refactor _notmuch_database_link_message
+In-Reply-To: <1412345958-8278-3-git-send-email-aclements@csail.mit.edu>
+References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu>
+	<1412345958-8278-3-git-send-email-aclements@csail.mit.edu>
+User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Sun, 05 Oct 2014 09:45:42 +0200
+Message-ID: <87k34fot7d.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 05 Oct 2014 07:45:57 -0000
+
+Austin Clements <aclements@csail.mit.edu> writes:
+> +    void *local = talloc_new (NULL);
+
+What's the advantage of using a local talloc context here? Is this just
+an optimization?
+
+d