From: David Bremner <david@tethera.net>
Date: Mon, 6 Jun 2016 15:03:56 +0000 (+2100)
Subject: Re: [PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=413d26013babc14c980509ba0b14ff92f3c02b60;p=notmuch-archives.git

Re: [PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION
---

diff --git a/b8/540cac8170ac307c925d5523686d86588597f4 b/b8/540cac8170ac307c925d5523686d86588597f4
new file mode 100644
index 000000000..1cf230c6f
--- /dev/null
+++ b/b8/540cac8170ac307c925d5523686d86588597f4
@@ -0,0 +1,67 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id BBCC16DE0130
+ for <notmuch@notmuchmail.org>; Mon,  6 Jun 2016 08:04:08 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: -0.012
+X-Spam-Level: 
+X-Spam-Status: No, score=-0.012 tagged_above=-999 required=5
+ tests=[AWL=-0.001, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id zlmHpbhp31nA for <notmuch@notmuchmail.org>;
+ Mon,  6 Jun 2016 08:04:00 -0700 (PDT)
+Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])
+ by arlo.cworth.org (Postfix) with ESMTPS id 5E89C6DE00DA
+ for <notmuch@notmuchmail.org>; Mon,  6 Jun 2016 08:03:59 -0700 (PDT)
+Received: from remotemail by fethera.tethera.net with local (Exim 4.84)
+ (envelope-from <david@tethera.net>)
+ id 1b9w4B-0000I8-8e; Mon, 06 Jun 2016 11:03:47 -0400
+Received: (nullmailer pid 6417 invoked by uid 1000);
+ Mon, 06 Jun 2016 15:03:56 -0000
+From: David Bremner <david@tethera.net>
+To: notmuch@notmuchmail.org
+Subject: Re: [PATCH] lib: fix definition of LIBNOTMUCH_CHECK_VERSION
+In-Reply-To: <1465225095-3098-1-git-send-email-david@tethera.net>
+References: <20160606124522.g2y2eazhhrwjsa4h@flatcap.org>
+ <1465225095-3098-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.22+28~gb9bf3f4 (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Mon, 06 Jun 2016 12:03:56 -0300
+Message-ID: <87lh2inyub.fsf@tesseract.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 06 Jun 2016 15:04:08 -0000
+
+David Bremner <david@tethera.net> writes:
+
+> Fix bug reported in id:20160606124522.g2y2eazhhrwjsa4h@flatcap.org
+>
+> Although the C99 standard 6.10 is a little non-obvious on this point,
+> the docs for e.g. gcc are unambiguous. And indeed in practice with the
+> extra space, this code fails
+>
+> int main(int argc, char **argv){
+>   printf("%d\n",foo(1));
+> }
+> ---
+
+Of course git removed the #define as a comment. sigh.
+
+d