From: Jani Nikula Date: Sun, 30 Aug 2015 07:47:06 +0000 (+0300) Subject: Re: [RFC PATCH 4/5] cli: change the data structure for notmuch address deduplication X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=41119e4b113319c2ecd400a4ffe981d916064dcf;p=notmuch-archives.git Re: [RFC PATCH 4/5] cli: change the data structure for notmuch address deduplication --- diff --git a/26/905d7ba4b35cedc0d908ce32139074109bb717 b/26/905d7ba4b35cedc0d908ce32139074109bb717 new file mode 100644 index 000000000..0b65a6219 --- /dev/null +++ b/26/905d7ba4b35cedc0d908ce32139074109bb717 @@ -0,0 +1,80 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 143D56DE17AA + for ; Sun, 30 Aug 2015 00:47:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.031 +X-Spam-Level: +X-Spam-Status: No, score=-0.031 tagged_above=-999 required=5 + tests=[AWL=-0.055, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, URIBL_SBL=0.644, URIBL_SBL_A=0.1] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DdNQPKiKsBe5 for ; + Sun, 30 Aug 2015 00:47:09 -0700 (PDT) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) + by arlo.cworth.org (Postfix) with ESMTPS id 2998E6DE1642 + for ; Sun, 30 Aug 2015 00:47:09 -0700 (PDT) +Received: by wicpl12 with SMTP id pl12so3334479wic.0 + for ; Sun, 30 Aug 2015 00:47:07 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=46gfGInbwfmY24IXn84mkwFi78h/Ng+nWOaAwA9TqW8=; + b=VS10N3A+qYvJO91xASaTKbMPxXYT0rGf4TEI1cP7lJTghr6wliHksdJHLgIfEN9hX6 + m/AyebrvBkrE9Scrx+PTKck7K/OJOQAt7js2twzPfaITZ7Tj71/rVW1Xew1Y1LRn3VMj + zkU8qJKEH26Y8B0nhkebWkEZxjSaN2J4QraZ2lRzEmhsgtHzn5zydX/ulohKiwYmGRse + aNpM8oIOOgzOfobRsWMJvGyf7aMJ0z4QF0EPMDka9UK+cke9UNavDwbjXUupBTwYTNJy + bmXpQ955LUvqzKRpEnmqYMH+KmxHUMjbnjrFhpqmR9LEyHngOXv2bz7JU1fmv6dOx07P + dJZQ== +X-Gm-Message-State: + ALoCoQlL201sFOQinrEa7pbKUEfMLf3hEDkqfe2v0sUi8VJPljkR/bUoXFronHkYyPXuJdwbYDIt +X-Received: by 10.194.81.67 with SMTP id y3mr19698969wjx.7.1440920827728; + Sun, 30 Aug 2015 00:47:07 -0700 (PDT) +Received: from localhost (mobile-access-bcee4f-131.dhcp.inet.fi. + [188.238.79.131]) + by smtp.gmail.com with ESMTPSA id ll1sm11992136wic.14.2015.08.30.00.47.06 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sun, 30 Aug 2015 00:47:07 -0700 (PDT) +From: Jani Nikula +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [RFC PATCH 4/5] cli: change the data structure for notmuch + address deduplication +In-Reply-To: <87a8t9tuka.fsf@maritornes.cs.unb.ca> +References: + + <87a8t9tuka.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+66~gb33abd9 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 30 Aug 2015 10:47:06 +0300 +Message-ID: <87egil1amd.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 30 Aug 2015 07:47:11 -0000 + +On Sun, 30 Aug 2015, David Bremner wrote: +> I guess this doesn't make the error handling worse; both old and new +> code silently ignore OOM if I understand correctly. + +Oh, and current git will not silently ignore OOM. It will segfault... ;) + +BR, +Jani.