From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Mon, 3 Jun 2013 17:25:24 +0000 (+0300)
Subject: Re: [RFC PATCH] emacs: Remove v command
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=4038da6e2447fb98f7d3524cd095d28321150810;p=notmuch-archives.git

Re: [RFC PATCH] emacs: Remove v command
---

diff --git a/0c/4b28191346577a83f4aa3e592dec6fdcb309b5 b/0c/4b28191346577a83f4aa3e592dec6fdcb309b5
new file mode 100644
index 000000000..38bb42131
--- /dev/null
+++ b/0c/4b28191346577a83f4aa3e592dec6fdcb309b5
@@ -0,0 +1,96 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1B408431FAF
+	for <notmuch@notmuchmail.org>; Mon,  3 Jun 2013 10:25:33 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id uQg5m02hg8oz for <notmuch@notmuchmail.org>;
+	Mon,  3 Jun 2013 10:25:25 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 7D4F6431FAE
+	for <notmuch@notmuchmail.org>; Mon,  3 Jun 2013 10:25:25 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id CB98E100030;
+	Mon,  3 Jun 2013 20:25:24 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
+Subject: Re: [RFC PATCH] emacs: Remove v command
+In-Reply-To: <1370274895-32098-1-git-send-email-amdragon@mit.edu>
+References: <1370274895-32098-1-git-send-email-amdragon@mit.edu>
+User-Agent: Notmuch/0.15.2+168~gf91ff62 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Mon, 03 Jun 2013 20:25:24 +0300
+Message-ID: <m2sj0z3y4b.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Mon, 03 Jun 2013 17:25:33 -0000
+
+On Mon, Jun 03 2013, Austin Clements <amdragon@MIT.EDU> wrote:
+
+> This removes the v command, since we now have much nicer part commands,
+> and deprecates the underlying notmuch-show-view-all-mime-parts.  This
+> also means that people who try using the old unprefixed 'v' command on
+> a part button will no longer be greeted by ALL of their parts popping
+> up.
+> ---
+
++1
+
+Tomi
+
+
+>  emacs/notmuch-show.el |    4 +++-
+>  1 file changed, 3 insertions(+), 1 deletion(-)
+>
+> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
+> index 5771950..bae3171 100644
+> --- a/emacs/notmuch-show.el
+> +++ b/emacs/notmuch-show.el
+> @@ -213,6 +213,9 @@ For example, if you wanted to remove an \"unread\" tag and add a
+>    "Enable Visual Line mode."
+>    (visual-line-mode t))
+>  
+> +;; DEPRECATED in Notmuch 0.16 since we now have convenient part
+> +;; commands.  We'll keep the command around for a version or two in
+> +;; case people want to bind it themselves.
+>  (defun notmuch-show-view-all-mime-parts ()
+>    "Use external viewers to view all attachments from the current message."
+>    (interactive)
+> @@ -1216,7 +1219,6 @@ reset based on the original query."
+>  	(define-key map "|" 'notmuch-show-pipe-message)
+>  	(define-key map "w" 'notmuch-show-save-attachments)
+>  	(define-key map "V" 'notmuch-show-view-raw-message)
+> -	(define-key map "v" 'notmuch-show-view-all-mime-parts)
+>  	(define-key map "c" 'notmuch-show-stash-map)
+>  	(define-key map "=" 'notmuch-show-refresh-view)
+>  	(define-key map "h" 'notmuch-show-toggle-visibility-headers)
+> -- 
+> 1.7.10.4
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch