From: Michal Sojka Date: Sat, 1 Nov 2014 09:21:16 +0000 (+0100) Subject: Re: [PATCH v6 7/7] cli: search: Add --filter-by option to configure address filtering X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3f2664bd56c988e1c1383fe662aaa13d725caed7;p=notmuch-archives.git Re: [PATCH v6 7/7] cli: search: Add --filter-by option to configure address filtering --- diff --git a/74/7ffe69152844308e5615db1ec7f0607baa7040 b/74/7ffe69152844308e5615db1ec7f0607baa7040 new file mode 100644 index 000000000..a69dec7ec --- /dev/null +++ b/74/7ffe69152844308e5615db1ec7f0607baa7040 @@ -0,0 +1,83 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BE2F9431FD0 + for ; Sat, 1 Nov 2014 02:21:36 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -2.3 +X-Spam-Level: +X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id AC-osod34mOi for ; + Sat, 1 Nov 2014 02:21:30 -0700 (PDT) +Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) + by olra.theworths.org (Postfix) with ESMTP id 16626431FAF + for ; Sat, 1 Nov 2014 02:21:30 -0700 (PDT) +Received: from localhost (unknown [192.168.200.7]) + by max.feld.cvut.cz (Postfix) with ESMTP id C83FC5CCF17; + Sat, 1 Nov 2014 10:21:25 +0100 (CET) +X-Virus-Scanned: IMAP STYX AMAVIS +Received: from max.feld.cvut.cz ([192.168.200.1]) + by localhost (styx.feld.cvut.cz [192.168.200.7]) (amavisd-new, + port 10044) + with ESMTP id a7fh1dNcWu86; Sat, 1 Nov 2014 10:21:21 +0100 (CET) +Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) + by max.feld.cvut.cz (Postfix) with ESMTP id 914805CCF12; + Sat, 1 Nov 2014 10:21:21 +0100 (CET) +Received: from wsh by steelpick.2x.cz with local (Exim 4.84) + (envelope-from ) + id 1XkUs0-0001em-0f; Sat, 01 Nov 2014 10:21:16 +0100 +From: Michal Sojka +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v6 7/7] cli: search: Add --filter-by option to + configure address filtering +In-Reply-To: <87mw8be1w2.fsf@nikula.org> +References: <1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz> + <1414792441-29555-8-git-send-email-sojkam1@fel.cvut.cz> + <87mw8be1w2.fsf@nikula.org> +User-Agent: Notmuch/0.18.2+157~ga00d359 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sat, 01 Nov 2014 10:21:16 +0100 +Message-ID: <87egtn2s4z.fsf@steelpick.2x.cz> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 01 Nov 2014 09:21:36 -0000 + +On Sat, Nov 01 2014, Jani Nikula wrote: +> On Fri, 31 Oct 2014, Michal Sojka wrote: +>> This option allows to configure the criterion for duplicate address +>> filtering. Without this option, all unique combinations of name and +>> address parts are printed. This option allows to filter the output +>> more, for example to only contain unique address parts. +> +> This patch finally makes me think we should have a separate 'notmuch +> address' command for all of this. We are starting to have two orthogonal +> sets of 'notmuch search' options, one set for search and another for +> addresses. I regret not following the series and then making the +> observation so late. + +To some extent it is true. The question is whether it would make sense +for 'notmuch address' to have options like --offset and --limit. +Probably not. + +I can prepare a new patchset implementing 'notmuch address' over the +weekend. It would be necessary to revert the last (or two) already +merged patch. What do others think? + +-Michal