From: Mark Walters Date: Wed, 23 Oct 2013 16:06:27 +0000 (+0100) Subject: Re: [PATCH v2 0/8] Improve tag change completion X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3ec1091fe6f878f40f8c115d32fb1553735a908a;p=notmuch-archives.git Re: [PATCH v2 0/8] Improve tag change completion --- diff --git a/5c/645d2dff62ca226198ccaa2fc0c9f1a5dff001 b/5c/645d2dff62ca226198ccaa2fc0c9f1a5dff001 new file mode 100644 index 000000000..5f3d0f28e --- /dev/null +++ b/5c/645d2dff62ca226198ccaa2fc0c9f1a5dff001 @@ -0,0 +1,133 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6A9FE431FC3 + for ; Wed, 23 Oct 2013 09:07:45 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id w1v3eigrSL6O for ; + Wed, 23 Oct 2013 09:07:39 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 52B75431FBC + for ; Wed, 23 Oct 2013 09:07:39 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VZ0y4-0001TK-Ri; Wed, 23 Oct 2013 17:07:33 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VZ0y4-0001kp-A7; Wed, 23 Oct 2013 17:07:32 +0100 +From: Mark Walters +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/8] Improve tag change completion +In-Reply-To: <1382487721-31776-1-git-send-email-amdragon@mit.edu> +References: <1382487721-31776-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 23 Oct 2013 17:06:27 +0100 +Message-ID: <87k3h40y64.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 3f5ceb6e7a115b9b128abc699ab9c329 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 23 Oct 2013 16:07:45 -0000 + + +In might of id:20131023154404.GE20337@mit.edu I am now happy with this +series. LGTM +1 + +Best wishes + +Mark + + +On Wed, 23 Oct 2013, Austin Clements wrote: +> This is v2 of id:1382471457-26056-1-git-send-email-amdragon@mit.edu. +> It improves some documentation strings, fixes one bug, and elimintes +> some redundant code. The diff from v1 is below. +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index ef77839..f66d669 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -1800,7 +1800,6 @@ See `notmuch-tag' for information on the format of TAG-CHANGES." +> (list (let (tags) +> (notmuch-show-mapc +> (lambda () (setq tags (append (notmuch-show-get-tags) tags)))) +> - (delete-dups tags) +> (notmuch-read-tag-changes tags "Tag thread")))) +> (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes) +> (notmuch-show-mapc +> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el +> index feee17c..7b21006 100644 +> --- a/emacs/notmuch-tag.el +> +++ b/emacs/notmuch-tag.el +> @@ -189,6 +189,9 @@ the messages that were tagged" +> `notmuch-read-tag-changes' function.") +> +> (defun notmuch-tag-completions (&rest search-terms) +> + "Return a list of tags for messages matching SEARCH-TERMS. +> + +> +Returns all tags if no search terms are given." +> (if (null search-terms) +> (setq search-terms (list "*"))) +> (split-string +> @@ -199,7 +202,7 @@ the messages that were tagged" +> "\n+" t)) +> +> (defun notmuch-select-tag-with-completion (prompt &rest search-terms) +> - (let ((tag-list (notmuch-tag-completions search-terms))) +> + (let ((tag-list (apply #'notmuch-tag-completions search-terms))) +> (completing-read prompt tag-list nil nil nil 'notmuch-select-tag-history))) +> +> (defun notmuch-read-tag-changes (current-tags &optional prompt initial-input) +> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> index 5492e1b..53e9826 100644 +> --- a/emacs/notmuch.el +> +++ b/emacs/notmuch.el +> @@ -584,7 +584,10 @@ Returns (TAG-CHANGES REGION-BEGIN REGION-END)." +> "Change tags for the currently selected thread or region. +> +> See `notmuch-tag' for information on the format of TAG-CHANGES. +> -If BEG or END are nil, applies to the thread at point." +> +When called interactively, this uses the region if the region is +> +active. When called directly, BEG and END provide the region. +> +If these are nil or not provided, this applies to the thread at +> +point." +> (interactive (notmuch-search-interactive-tag-changes)) +> (unless (and beg end) (setq beg (point) end (point))) +> (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))