From: Peter Wang Date: Wed, 11 Sep 2013 14:13:49 +0000 (+1000) Subject: Re: [PATCH 1/3] cli: add insert --must-index option X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3dfc4c7a5ea7a83223f20302291f4b2c3a427c88;p=notmuch-archives.git Re: [PATCH 1/3] cli: add insert --must-index option --- diff --git a/b1/658c383592b1f0bed5365674a9f46f28b95882 b/b1/658c383592b1f0bed5365674a9f46f28b95882 new file mode 100644 index 000000000..a14113b53 --- /dev/null +++ b/b1/658c383592b1f0bed5365674a9f46f28b95882 @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C61D4431FAF + for ; Wed, 11 Sep 2013 07:14:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.099 +X-Spam-Level: +X-Spam-Status: No, score=-0.099 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id sUFlCAMFQnlh for ; + Wed, 11 Sep 2013 07:13:58 -0700 (PDT) +Received: from mail-pd0-f172.google.com (mail-pd0-f172.google.com + [209.85.192.172]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 366AF431FAE + for ; Wed, 11 Sep 2013 07:13:58 -0700 (PDT) +Received: by mail-pd0-f172.google.com with SMTP id z10so9245750pdj.31 + for ; Wed, 11 Sep 2013 07:13:56 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=date:message-id:from:to:cc:subject:in-reply-to:references + :mime-version:content-type:content-disposition + :content-transfer-encoding; + bh=ty5zMNmhBdqZEu4Sm/avDtvcBpTPSj3kIcERbW6Pp48=; + b=iSNfK1maHfwWuSBsTp5bKDoRVEos8JAIpQWcW6n4BqOyAelINVzgKwU7dIk6j+7plF + D2Ks5ga+DjVkTbyTsiKj75ANKmETMnUkocWK7NSuiXHUgnWZPsFzpHEHjUShnl3NS7nb + pE/45D5xcwHlyCoFvX+kntlAtW7+Mmj2Vt+I0V9bcMr65mj3vdCuszHlnEnwOxs8DkX+ + s80BVqDunret8EUXpK4YM+/nbY18fK0/VDWxQHPl3PiCSVxR5+EViuJqDN/ZOKwkwRrG + /OqxQdN/9GTwGbXmKnXqqU107lCg+2AxNugq+iVTf12RS0tSXBme+fC6LnoA3/obq6h2 + Wlcw== +X-Received: by 10.67.14.67 with SMTP id fe3mr3959503pad.134.1378908835283; + Wed, 11 Sep 2013 07:13:55 -0700 (PDT) +Received: from localhost (215.42.233.220.static.exetel.com.au. + [220.233.42.215]) by mx.google.com with ESMTPSA id + sy2sm30087727pbc.16.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Wed, 11 Sep 2013 07:13:54 -0700 (PDT) +Date: Thu, 12 Sep 2013 00:13:49 +1000 +Message-ID: <20130912001349.GA18821@hili.localdomain> +From: Peter Wang +To: Mark Walters +Subject: Re: [PATCH 1/3] cli: add insert --must-index option +In-Reply-To: <87hadtxfrr.fsf@qmul.ac.uk> +References: <1374365254-13227-1-git-send-email-novalazy@gmail.com> + <87ip048gbj.fsf@qmul.ac.uk> + <20130727151510.GA13750@hili.localdomain> + <87hadtxfrr.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: 8bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 11 Sep 2013 14:14:04 -0000 + +On Tue, 10 Sep 2013 09:06:00 +0100, Mark Walters wrote: +> +> Alternatively maybe add notmuch_database_destroy_with_flush or something +> which does give a return value. notmuch_database_close is only called 3 +> times and notmuch_database_destroy lots of times so changing close is +> much less intrusive than changing destroy. But I don't know whether we +> would break any bindings or external programs etc. +> +> What do you think? + +I think notmuch_database_close and notmuch_database_destroy should +return the status, and we update the three language bindings +and bump the soname. + +Peter