From: David Bremner <david@tethera.net>
Date: Sun, 30 Aug 2015 12:28:32 +0000 (+2100)
Subject: Re: [PATCH 1/2] emacs: add defsubst notmuch-address--message-insinuated
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3dfa587a1598694c7e21dee8e47cbf6865c6b700;p=notmuch-archives.git

Re: [PATCH 1/2] emacs: add defsubst notmuch-address--message-insinuated
---

diff --git a/5b/ed18b3c8aa46522d13856896ca629f49fa992e b/5b/ed18b3c8aa46522d13856896ca629f49fa992e
new file mode 100644
index 000000000..158355f25
--- /dev/null
+++ b/5b/ed18b3c8aa46522d13856896ca629f49fa992e
@@ -0,0 +1,62 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 9FA006DE17FD
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 05:29:52 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.117
+X-Spam-Level: 
+X-Spam-Status: No, score=0.117 tagged_above=-999 required=5 tests=[AWL=0.117]
+ autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id uEMaZQ06zLBS for <notmuch@notmuchmail.org>;
+ Sun, 30 Aug 2015 05:29:50 -0700 (PDT)
+Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
+ by arlo.cworth.org (Postfix) with ESMTPS id 9CBB86DE17EB
+ for <notmuch@notmuchmail.org>; Sun, 30 Aug 2015 05:29:50 -0700 (PDT)
+Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
+ (envelope-from <david@tethera.net>)
+ id 1ZW1jB-0007LW-Co; Sun, 30 Aug 2015 12:28:53 +0000
+Received: (nullmailer pid 3529 invoked by uid 1000); Sun, 30 Aug 2015
+ 12:28:32 -0000
+From: David Bremner <david@tethera.net>
+To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
+Subject: Re: [PATCH 1/2] emacs: add defsubst
+ notmuch-address--message-insinuated
+In-Reply-To: <1440619626-18768-1-git-send-email-tomi.ollila@iki.fi>
+References: <1440619626-18768-1-git-send-email-tomi.ollila@iki.fi>
+User-Agent: Notmuch/0.20.2+60~gcb08a2e (http://notmuchmail.org) Emacs/24.5.1
+ (x86_64-pc-linux-gnu)
+Date: Sun, 30 Aug 2015 09:28:32 -0300
+Message-ID: <87y4gtrmdr.fsf@maritornes.cs.unb.ca>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: tomi.ollila@iki.fi
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.18
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sun, 30 Aug 2015 12:29:52 -0000
+
+Tomi Ollila <tomi.ollila@iki.fi> writes:
+
+> +(defsubst notmuch-address--message-insinuated ()
+> +  (memq notmuch-address-message-alist-member message-completion-alist))
+> +
+
+Is there some advantage to defsubst other than (maybe?) performance?  It
+just seems like one more construct for people to get up to speed with
+the codebase.
+
+d