From: Ramkumar Ramachandra Date: Sat, 2 Oct 2010 04:37:43 +0000 (+0530) Subject: SubmittingPatches: Document some extra tags used in commit messages X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3d3ca534beb71e0b2ca3505f9b347229d91a4e02;p=signed-off-by.git SubmittingPatches: Document some extra tags used in commit messages Document the meanings of the tags "Reported-by:", "Acked-by:", "Reviewed-by:" and "Tested-by:" clearly. Also mention that the user is free to use any custom tags. Helped-by: Jonathan Nieder Liked-by: Sverre Rabbelier Signed-off-by: Ramkumar Ramachandra Signed-off-by: Junio C Hamano [wking@tremily.us: removed diff context to merge with Linux kernel version] Signed-off-by: W. Trevor King --- diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches index aa1ac1e..e88d00c 100644 --- a/Documentation/SubmittingPatches +++ b/Documentation/SubmittingPatches @@ -53,12 +53,21 @@ the change to its true author (see (2) above). Also notice that a real name is used in the Signed-off-by: line. Please don't hide your real name. -Some people also put extra tags at the end. - -"Acked-by:" says that the patch was reviewed by the person who -is more familiar with the issues and the area the patch attempts -to modify. "Tested-by:" says the patch was tested by the person -and found to have the desired effect. +If you like, you can put extra tags at the end: + +1. "Reported-by:" is used to to credit someone who found the bug that + the patch attempts to fix. +2. "Acked-by:" says that the person who is more familiar with the area + the patch attempts to modify liked the patch. +3. "Reviewed-by:", unlike the other tags, can only be offered by the + reviewer and means that she is completely satisfied that the patch + is ready for application. It is usually offered only after a + detailed review. +4. "Tested-by:" is used to indicate that the person applied the patch + and found it to have the desired effect. + +You can also create your own tag or use one that's in common usage +such as "Thanks-to:", "Based-on-patch-by:", or "Mentored-by:". If you are a subsystem or branch maintainer, sometimes you need to slightly modify patches you receive in order to merge them, because the code is not