From: Robert Bradshaw <robertwb@math.washington.edu>
Date: Sat, 14 Mar 2009 21:15:31 +0000 (-0700)
Subject: Reduce code size for tuple unpacking.
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3d30a2a755ee80602a490f1e3b1c3557bf8a2bf8;p=cython.git

Reduce code size for tuple unpacking.
---

diff --git a/Cython/Compiler/ExprNodes.py b/Cython/Compiler/ExprNodes.py
index c57b8e8f..5147f37f 100644
--- a/Cython/Compiler/ExprNodes.py
+++ b/Cython/Compiler/ExprNodes.py
@@ -3042,21 +3042,10 @@ class SequenceNode(NewTempExprNode):
         code.putln("} else {")
 
         if rhs.type is tuple_type:
-            code.globalstate.use_utility_code(raise_none_iter_error_utility_code)
-            code.putln("if (%s == Py_None) {" %
-                       rhs.py_result())
-            code.putln("__Pyx_RaiseNoneNotIterableError();")
-            code.putln("} else if (PyTuple_GET_SIZE(%s) < %s) {" % (
-                rhs.py_result(), len(self.args)))
-            code.globalstate.use_utility_code(raise_need_more_values_to_unpack)
-            code.putln("__Pyx_RaiseNeedMoreValuesError(PyTuple_GET_SIZE(%s));" %
-                       rhs.py_result());
-            code.putln("} else {")
-            code.globalstate.use_utility_code(raise_need_more_values_to_unpack)
-            code.putln("__Pyx_RaiseTooManyValuesError();");
-            code.putln("}")
-            code.putln(
-                code.error_goto(self.pos))
+            code.globalstate.use_utility_code(tuple_unpacking_error_code)
+            code.putln("__Pyx_UnpackTupleError(%s, %s);" % (
+                        rhs.py_result(), len(self.args)))
+            code.putln(code.error_goto(self.pos))
         else:
             code.putln(
                 "%s = PyObject_GetIter(%s); %s" % (
@@ -5570,6 +5559,26 @@ static INLINE void __Pyx_RaiseNeedMoreValuesError(Py_ssize_t index) {
 
 #------------------------------------------------------------------------------------
 
+tuple_unpacking_error_code = UtilityCode(
+proto = """
+static void __Pyx_UnpackTupleError(PyObject *, Py_ssize_t index); /*proto*/
+""", 
+impl = """
+static void __Pyx_UnpackTupleError(PyObject *t, Py_ssize_t index) {
+    if (t == Py_None) {
+      __Pyx_RaiseNoneNotIterableError();
+    } else if (PyTuple_GET_SIZE(t) < index) {
+      __Pyx_RaiseNeedMoreValuesError(PyTuple_GET_SIZE(t));
+    } else {
+      __Pyx_RaiseTooManyValuesError();
+    }
+}
+""", 
+requires = [raise_none_iter_error_utility_code,
+            raise_need_more_values_to_unpack,
+            raise_too_many_values_to_unpack]
+)
+
 unpacking_utility_code = UtilityCode(
 proto = """
 static PyObject *__Pyx_UnpackItem(PyObject *, Py_ssize_t index); /*proto*/