From: David Edmondson Date: Mon, 11 Apr 2016 07:39:27 +0000 (+0100) Subject: Re: Breaking a really long thread X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3d0579f5f619c3a12c9b9e96b0382165fd0015e7;p=notmuch-archives.git Re: Breaking a really long thread --- diff --git a/d3/8d63dd9ddfe373abf187d69c79cdbb8e993a6b b/d3/8d63dd9ddfe373abf187d69c79cdbb8e993a6b new file mode 100644 index 000000000..7bcb31582 --- /dev/null +++ b/d3/8d63dd9ddfe373abf187d69c79cdbb8e993a6b @@ -0,0 +1,142 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 0111F6DE0352 + for ; Mon, 11 Apr 2016 00:39:40 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.176 +X-Spam-Level: +X-Spam-Status: No, score=-0.176 tagged_above=-999 required=5 + tests=[AWL=-0.109, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 6Vi0B7-tQdtc for ; + Mon, 11 Apr 2016 00:39:32 -0700 (PDT) +Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com + [74.125.82.53]) by arlo.cworth.org (Postfix) with ESMTPS id A9F846DE02D7 for + ; Mon, 11 Apr 2016 00:39:31 -0700 (PDT) +Received: by mail-wm0-f53.google.com with SMTP id v188so74495148wme.1 + for ; Mon, 11 Apr 2016 00:39:31 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version; + bh=RtwgletXmC1CMcjoKvqJrFe9oOqCOX3PvxYC/ovRvZM=; + b=jSxFO2CQDuQrTlwd2rKCZEY3aARRlLDUBsZNtEJDMF6tmF4t2haOy1341SojTUB9pz + Cmo04DwqzFsHyEMnzM1POQBfKelGtA2mUhvfMBoNXtGy3ss+paKg94HcEgtrgb+Y2nOa + I9MLr4Rw0Xkpo8kHlbuLafQCNqKRjDDSFOmj4LfayFGcmR6LG/4VHlYt1+0nOAX9+57z + pivrBc6lm9zmNW6q8JiXqcZfgKsj8PSjdgoj9sGDggccHZUIBwaLe/komgjsgZAzpfFQ + Lqilf38GUZkQ49ZyTJ3OvmHYLqyd/eQDKaVwMxq6DaHDdv7ig/DeJwh/WYkzQWKKawO/ + p5uA== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version; + bh=RtwgletXmC1CMcjoKvqJrFe9oOqCOX3PvxYC/ovRvZM=; + b=REZo70RU7d/vUOyhihA7dR5L1chVF8V8EjLb96an9skL0EHwnC2WxA7MvQB2xB4zDk + tSjqgMbVUS7x99qJsq/Fd1PcmE5p+ztUlbdZOQs6yRUwFrSGMvBtY8b+hkHr7Q1Aa4Dh + Cg/Rd+rvP8PI4DIH6F9C2h3fSFu6kgfWuks5g1OOB5k5NtICm7X1J8MCdQ+TSsS4tBag + zu5Bk43c3nqzSnLn0p/e9s19zwsh0yHB8u3BVU0QZxhTO5xeLsDKd4dNkgv2HwxG4Snb + VvD34Y+WO5nHDY7QIVDniHPKHDZER8QbDjpAheKFYr5CEHpqwBzawYW8ch6qb00jFEud + u0bA== +X-Gm-Message-State: + AD7BkJKoCcwAlM5opniE6ti2LJgrqhyWz2Kz/aTDHhjiqNHXoiq7StUkIUPvGnK491EDKw== +X-Received: by 10.194.138.37 with SMTP id qn5mr22265859wjb.108.1460360370384; + Mon, 11 Apr 2016 00:39:30 -0700 (PDT) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id 7sm15876776wmn.7.2016.04.11.00.39.28 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 11 Apr 2016 00:39:29 -0700 (PDT) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id aa9a0bbb; + Mon, 11 Apr 2016 07:39:28 +0000 (UTC) +To: Mark Walters , + David Bremner , + Daniel Kahn Gillmor ,David Mazieres expires 2016-07-03 + PDT , notmuch@notmuchmail.org +Subject: Re: Breaking a really long thread +In-Reply-To: <87y48kipdw.fsf@qmul.ac.uk> +References: + <87k2kd8r6d.fsf@qmul.ac.uk> <87wpoc7hf8.fsf@ta.scs.stanford.edu> + <8760vrm3jk.fsf@alice.fifthhorseman.net> <87fuuu3938.fsf@zancas.localnet> + <87bn5ijthh.fsf@qmul.ac.uk> <87oa9g7vd6.fsf@zancas.localnet> + <87y48kipdw.fsf@qmul.ac.uk> +From: David Edmondson +Date: Mon, 11 Apr 2016 08:39:27 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 11 Apr 2016 07:39:40 -0000 + +On Mon, Apr 11 2016, Mark Walters wrote: +> On Mon, 11 Apr 2016, David Bremner wrote: +>> Mark Walters writes: +>> +>>> I think we already have this, except it is called +>>> notmuch-mua-hidden-headers. It defaults to '("^User-Agent:"). +>>> +>>> I think it would be reasonable to add In-Reply-To to this list. +>>> +>>> However, if I read the code correctly, currently we are changing +>>> message-hidden-headers globally which doesn't feel the right thing to +>>> do. Probably we should do something more like you suggest, and do the +>>> overriding just in notmuch-message-mode. +>>> +>> +>> Summarizing, I see 3 related changes here +>> +>> - fixing the code to let-bind message-hidden-headers instead of globally +>> modify it +> +> I have a patch doing this, but there is one problem that i don't see how +> to solve neatly. At the moment we set hidden-headers to the union of +> message-hidden-headers and notmuch-mua-hidden-headers. This means that +> if the user wants to show a header that is normally one of +> message-hidden-headers they have to set message-hidden-headers (ie they +> can't just change notmuch-mua-hidden headers). +> +> If we want it that people can show such a header just by changing a +> notmuch variable then I don't see how to do it neatly without breaking +> some existing setups. +> +> Any suggestions? + +My inclination is to say "if you want to change the headers that are +hidden in message mode, change `message-hidden-headers'" and don't +bother with any notmuch specific settings. + +That, of course, leads me to wonder why I ever added +`notmuch-mua-hidden-headers' in the first place... + +> Best wishes +> +> Mark +> +>> +>> - adding in-reply-to notmuch-mua +>> +>> - providing a keybinding to toggle visibility of hidden headers that +>> works better than the current use of widen +>> +>> d +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch