From: Jaime Velasco Date: Wed, 20 Jul 2016 08:59:00 +0000 (+0100) Subject: Re: [PATCH] Fix typo in Message.maildir_flags_to_tags X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3c7ab639d5ec3192a46e7eeb45f5d1844ff254f8;p=notmuch-archives.git Re: [PATCH] Fix typo in Message.maildir_flags_to_tags --- diff --git a/cb/ce0e8da51c9fb67752334892fcedcc1e0c65fb b/cb/ce0e8da51c9fb67752334892fcedcc1e0c65fb new file mode 100644 index 000000000..4ed081e71 --- /dev/null +++ b/cb/ce0e8da51c9fb67752334892fcedcc1e0c65fb @@ -0,0 +1,148 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 048F86DE012F + for ; Wed, 20 Jul 2016 01:59:10 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.819 +X-Spam-Level: +X-Spam-Status: No, score=-0.819 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, + RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 66I3eKgiNs3N for ; + Wed, 20 Jul 2016 01:59:02 -0700 (PDT) +Received: from mail-qk0-f193.google.com (mail-qk0-f193.google.com + [209.85.220.193]) + by arlo.cworth.org (Postfix) with ESMTPS id CD94E6DE00DF + for ; Wed, 20 Jul 2016 01:59:01 -0700 (PDT) +Received: by mail-qk0-f193.google.com with SMTP id p126so3495549qke.1 + for ; Wed, 20 Jul 2016 01:59:01 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:in-reply-to:references:from:date:message-id:subject:to + :cc; bh=lE1cO4BtEwhQ7zJUYqVatf8TNELwUaDi9xkXGUo1NEs=; + b=mrNOCvrDGrHZDZB5Jan0xRoeavjUxiWtVjpSu6eN5EyrtgE2yI0HWKnkIvQ893YL+K + Zb7+wA6RTMTtbKAB1pVv/2A3irSXTId7HgPU+tZO/huSajLpmPc4OSeZwUMrJOLkWXbH + 3g2ShTi6LrCmBb6woFGoCt/hNfWDRIFeLkRyFbPkJG/BuDDDHh7ootuRKR2TSVXeBoWw + cQmlqYfKLZECotgPOETKcssKFVUVox3W9ysNIe0ick7NOgDz8p0plcnEv2iG4KvpKp4w + bWgN9zV4R37vW+3hQJPvz6UIsrzt/OWSQsO7PK3U7ARGv17puWR8MczBeb+e9Rrx2acJ + dgwA== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:mime-version:in-reply-to:references:from:date + :message-id:subject:to:cc; + bh=lE1cO4BtEwhQ7zJUYqVatf8TNELwUaDi9xkXGUo1NEs=; + b=KonJsLsBOeAHWEBw8EKQFvdrAWprTm8DpfrGI84Y5eO5bgVHYJ5CsU43y2U+tm+sFU + JMzm4Q6vtQRtpFmT9Ybh6kjq/pY4btJDiK59Aj/03vKgWZQTxJ3OzOQO3KPTxwshAGR1 + hhXl6XkATyEYuX/9NX5a4gLdCq0+MU5Z1JTOYqkUYWaH25vwQ4Hl6KjGt/7QiUo97nM4 + 8ZnfDjZ+wjNds7o6ZD/3IDeKsgKM9+MJm8oqTeTwH0QP1n7JeHPrQJpbjJwW456Mdvo9 + UqGp2TpUqrFsrTejqeQq0E7YieV60ns5gkbmV/eOHBKqqjEE5szgFShoFm9dGogxHydV + WHTw== +X-Gm-Message-State: ALyK8tJ99xlJVrppvkxrs1iq/ywhIzmkfRRJNyU7iJrnPGoZt2CASw8v66HW2kcphYrjXU4sQmyyYwa7O3nvvg== +X-Received: by 10.55.33.138 with SMTP id f10mr59129406qki.86.1469005140625; + Wed, 20 Jul 2016 01:59:00 -0700 (PDT) +MIME-Version: 1.0 +Received: by 10.237.37.113 with HTTP; Wed, 20 Jul 2016 01:59:00 -0700 (PDT) +In-Reply-To: <1467658171-17819-1-git-send-email-jsagarribay@gmail.com> +References: <1467658171-17819-1-git-send-email-jsagarribay@gmail.com> +From: Jaime Velasco +Date: Wed, 20 Jul 2016 09:59:00 +0100 +Message-ID: + +Subject: Re: [PATCH] Fix typo in Message.maildir_flags_to_tags +To: notmuch@notmuchmail.org +Cc: Jaime Velasco Juan +Content-Type: multipart/alternative; boundary=001a113a0d16948d9805380d694c +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 20 Jul 2016 08:59:10 -0000 + +--001a113a0d16948d9805380d694c +Content-Type: text/plain; charset=UTF-8 + +Hi, is there anything I can fix to get the patch commited? + +Regards + +2016-07-04 19:49 GMT+01:00 Jaime Velasco Juan : + +> It has been calling _tags_to_maildir_flags instead since the beginning, +> --- +> bindings/python/notmuch/message.py | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/bindings/python/notmuch/message.py +> b/bindings/python/notmuch/message.py +> index bf80900..fc177eb 100644 +> --- a/bindings/python/notmuch/message.py +> +++ b/bindings/python/notmuch/message.py +> @@ -572,7 +572,7 @@ class Message(Python3StringMixIn): +> notmuch.STATUS.SUCCESS here. See there for details.""" +> if not self._msg: +> raise NotInitializedError() +> - return Message._tags_to_maildir_flags(self._msg) +> + return Message._maildir_flags_to_tags(self._msg) +> +> def __repr__(self): +> """Represent a Message() object by str()""" +> -- +> 2.8.1 +> +> + +--001a113a0d16948d9805380d694c +Content-Type: text/html; charset=UTF-8 +Content-Transfer-Encoding: quoted-printable + +
Hi, is there anything I can fix to get the patch comm= +ited?

Regards
2016-07-04 19:49 GMT+01:00 Jaime Velasco Juan <= +span dir=3D"ltr"><jsagarribay@gmail.com>:
It has been calling _tags_to_maildir_flags instead since the beginning, +---
+=C2=A0bindings/python/notmuch/message.py | 2 +-
+=C2=A01 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/bindings/python/notmuch/message.py b/bindings/python/notmuch/m= +essage.py
+index bf80900..fc177eb 100644
+--- a/bindings/python/notmuch/message.py
++++ b/bindings/python/notmuch/message.py
+@@ -572,7 +572,7 @@ class Message(Python3StringMixIn):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0notmuch.STATUS.SUCCESS here= +. See there for details."""
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if not self._msg:
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0raise NotInitializedError()= +
+-=C2=A0 =C2=A0 =C2=A0 =C2=A0 return Message._tags_to_maildir_flags(self._ms= +g)
++=C2=A0 =C2=A0 =C2=A0 =C2=A0 return Message._maildir_flags_to_tags(self._ms= +g)
+
+=C2=A0 =C2=A0 =C2=A0def __repr__(self):
+=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"""Represent a Message() o= +bject by str()"""
+--
+2.8.1
+
+

+ +--001a113a0d16948d9805380d694c--