From: Mark Walters Date: Sun, 1 Sep 2013 17:13:59 +0000 (+0100) Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3c71aff97bf2b4966ae8d3e7167774fae32cbd62;p=notmuch-archives.git Re: [PATCH] emacs: add buttons for all multipart/related parts --- diff --git a/7b/77d0657ef8094cc9befb4f3b060d9dbf232dd9 b/7b/77d0657ef8094cc9befb4f3b060d9dbf232dd9 new file mode 100644 index 000000000..17feb1f67 --- /dev/null +++ b/7b/77d0657ef8094cc9befb4f3b060d9dbf232dd9 @@ -0,0 +1,129 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1426F431FC0 + for ; Sun, 1 Sep 2013 10:14:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.401 +X-Spam-Level: * +X-Spam-Status: No, score=1.401 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ktuiO3+Sz0q8 for ; + Sun, 1 Sep 2013 10:14:07 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D5F54431FAF + for ; Sun, 1 Sep 2013 10:14:06 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VGBDu-0001xs-OC; Sun, 01 Sep 2013 18:14:05 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VGBDt-00078v-H4; Sun, 01 Sep 2013 18:14:01 +0100 +From: Mark Walters +To: Istvan Marko , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: add buttons for all multipart/related parts +In-Reply-To: +References: +User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 01 Sep 2013 18:13:59 +0100 +Message-ID: <871u58lb1k.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: b43aa68e48acbff414177ce82b8a0f9e (of first 20000 bytes) +X-SpamAssassin-Score: 0.6 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.6 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 1.0 FREEMAIL_REPLY From and body contain different freemails + * -0.4 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 01 Sep 2013 17:14:15 -0000 + + +On Fri, 16 Aug 2013, Istvan Marko wrote: +> When text/html parts include images as multipart/related and the +> text/plain alternative is used these images can be completely hidden +> with no easy way to access them or even find out that they are there. +> +> Make notmuch-show-insert-part-multipart/related add buttons for all +> parts, the first one visible the rest hidden. + +Hello + +This patch LGTM +1. + +It is a clear improvement anyway but would benefit from my fix for the +bug this exposes +id:1377246875-7784-1-git-send-email-markwalters1009@gmail.com (or some +alternative). I don't know if we want to push the two together or just +push each as it gets reviewed. + +Best wishes + +Mark + + + + + + +> --- +> emacs/notmuch-show.el | 4 ++++ +> 1 file changed, 4 insertions(+) +> +> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el +> index 82b70ba..20844f0 100644 +> --- a/emacs/notmuch-show.el +> +++ b/emacs/notmuch-show.el +> @@ -621,6 +621,10 @@ message at DEPTH in the current thread." +> +> ;; Render the primary part. +> (notmuch-show-insert-bodypart msg (car inner-parts) depth) +> + ;; Add hidden buttons for the rest +> + (mapc (lambda (inner-part) +> + (notmuch-show-insert-bodypart msg inner-part depth t)) +> + (cdr inner-parts)) +> +> (when notmuch-show-indent-multipart +> (indent-rigidly start (point) 1))) +> -- +> 1.8.1.4 +> +> +> +> +> -- +> Istvan +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch