From: Karl Fogel Date: Mon, 7 Jul 2014 17:35:54 +0000 (+1900) Subject: Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3c6ff080daa9da171179f0e32cb574d91ebf3d16;p=notmuch-archives.git Re: [PATCH] emacs: add missing paren to fix defun in notmuch-address.el. --- diff --git a/ec/6637d1e20127325f1e186c05814ea5202e2cdd b/ec/6637d1e20127325f1e186c05814ea5202e2cdd new file mode 100644 index 000000000..c359f8967 --- /dev/null +++ b/ec/6637d1e20127325f1e186c05814ea5202e2cdd @@ -0,0 +1,107 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 116AE431FBC + for ; Mon, 7 Jul 2014 10:36:06 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.699 +X-Spam-Level: +X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, + RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id egP7uknrAmKd for ; + Mon, 7 Jul 2014 10:35:58 -0700 (PDT) +Received: from mail-ie0-f180.google.com (mail-ie0-f180.google.com + [209.85.223.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 49EBC431FAF + for ; Mon, 7 Jul 2014 10:35:58 -0700 (PDT) +Received: by mail-ie0-f180.google.com with SMTP id tr6so2002221ieb.39 + for ; Mon, 07 Jul 2014 10:35:56 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=sender:from:to:cc:subject:references:reply-to:date:in-reply-to + :message-id:user-agent:mime-version:content-type + :content-transfer-encoding; + bh=huwzrMNlwIpyn7WZpuO57JTgY4ZWyiHK7VH63AOjLM4=; + b=JOF9BeWwjM/Z/lQfn0ffkR+2Kma0NDUSZbG18Xl4Z/gJNZTKmbKJyDZ+0u6QJaakMn + rOuDiznRXlV7wKT/7BqFg6qMfk9csLWF+6iEs8JzFpGsV4iPYDiPyAOQLFEQjsvO0wwO + Z2tFEjLeYEZPQy8jta66egufpfahf+ZpvcWmnW/B8ln9V52Bqu4dEU/UWHxXkYsF8dx6 + wY2W1+GnRsWsqLm5ERoSep0S9LD8sf2nRQEEROpE8Ndl6B9SqjRSrtsT9na1QUuISdNp + 1mjOsgB+rzUw1yX14XWqKNH2R1V6/HFzhEUM4Ha7ww+m4peAFw/5Xf/0rLG9nFPllSgE + 2hfQ== +X-Received: by 10.42.104.75 with SMTP id q11mr33902844ico.35.1404754556839; + Mon, 07 Jul 2014 10:35:56 -0700 (PDT) +Received: from ktab.red-bean.com + (74-92-190-113-Illinois.hfc.comcastbusiness.net. [74.92.190.113]) + by mx.google.com with ESMTPSA id t1sm91837123igh.9.2014.07.07.10.35.55 + for + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Mon, 07 Jul 2014 10:35:56 -0700 (PDT) +Sender: Karl Fogel +From: Karl Fogel +To: Sebastian Lipp +Subject: Re: [PATCH] emacs: add missing paren to fix defun in + notmuch-address.el. +References: <87wqsfik5l.fsf@floss.red-bean.com> + <87mwtah2hd.fsf@zancas.localnet> <877gkeau42.fsf@floss.red-bean.com> + <8738v1jtzc.fsf@nikula.org> + <87k3odgutd.fsf@zancas.localnet> <87ip3wbj7g.fsf@mcs.anl.gov> + <87vc7vgbym.fsf@zancas.localnet> + + <87pphmc604.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + <87oax6vt4u.fsf@ktab.red-bean.com> + <87r4215vcd.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + <87d2djr7o1.fsf@floss.red-bean.com> + <878uo6dxup.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> +Date: Mon, 07 Jul 2014 12:35:54 -0500 +In-Reply-To: + <878uo6dxup.fsf@verb.i-did-not-set--mail-host-address--so-tickle-me> + (Sebastian Lipp's message of "Sun, 06 Jul 2014 22:41:02 +0200") +Message-ID: <8761j9kr5x.fsf@ktab.red-bean.com> +User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: Tomi Ollila , notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +Reply-To: Karl Fogel +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 07 Jul 2014 17:36:06 -0000 + +Sebastian Lipp writes: +>Karl Fogel +>> In general, supplying a log message with the patch with avoid such +>> confusion. If there is some prose expressing what the change is +>> supposed to to, and giving any historical context (such as the mailing +>> list thread starting from last year), then it will be easy for any +>> reviewer to understand what the patch is intended to do, and check if it +>> actually does that. +> +>Okay, next time I will provide that information inline. Thought keeping +>References and In-Reply-To headers would be sufficient reference. + +Well, when the patch is committed into a version control system, it's +going to need a log message (commit message) anyway. Since that message +is considered part of the change -- anyone reading the change will start +by reading the commit message -- it's typical to just include it with +the diff. + +The commit message can certainly include a reference to the email +thread; in fact, it's good if it does so. + +Best, +=C2=ADKarl