From: Zac Medico <zmedico@gentoo.org>
Date: Wed, 1 Oct 2008 17:43:37 +0000 (-0000)
Subject: Generate an eqawarn message if econf is called from src_compile and
X-Git-Tag: v2.2_rc12~49
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3ad44074411171205a34142c9932927404f42593;p=portage.git

Generate an eqawarn message if econf is called from src_compile and
src_configure is also defined. Thanks to Betelgeuse for the patch which
I've modified to be silent in EAPI 0 or 1 in case ebuilds want to define
src_configure in those EAPIs and call it manually from src_compile.

svn path=/main/trunk/; revision=11603
---

diff --git a/bin/ebuild.sh b/bin/ebuild.sh
index 987d1a475..041d5fa4d 100755
--- a/bin/ebuild.sh
+++ b/bin/ebuild.sh
@@ -436,6 +436,10 @@ econf() {
 	local x
 	local LOCAL_EXTRA_ECONF="${EXTRA_ECONF}"
 
+	! hasq "$EAPI" 0 1 && [[ $EBUILD_PHASE = compile && \
+		$(type -t src_configure) = function ]] && \
+		eqawarn "econf called in src_compile instead of src_configure"
+
 	if [ -z "${ECONF_SOURCE}" ]; then
 		ECONF_SOURCE="."
 	fi