From: Zac Medico <zmedico@gentoo.org>
Date: Thu, 1 Nov 2007 17:49:49 +0000 (-0000)
Subject: Make the EbuildUselessCdS check for both quoted and unquoted ${S}
X-Git-Tag: v2.2_pre1~472
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3a95784f6ba9ebc2b79a96d1220d23497bc1a360;p=portage.git

Make the EbuildUselessCdS check for both quoted and unquoted ${S}
so the user doesn't have to fix quoting before this check will
recognize the violation.

svn path=/main/trunk/; revision=8353
---

diff --git a/pym/repoman/checks.py b/pym/repoman/checks.py
index eea7ba40f..d6fcc1318 100644
--- a/pym/repoman/checks.py
+++ b/pym/repoman/checks.py
@@ -248,7 +248,7 @@ class EbuildUselessCdS(ContentCheck):
 	"""Check for redundant cd ${S} statements"""
 	repoman_check_name = 'ebuild.minorsyn'
 	method_re = re.compile(r'^\s*src_(compile|install|test)\s*\(\)')
-	cds_re = re.compile(r'^\s*cd\s+"\$(\{S\}|S)"\s')
+	cds_re = re.compile(r'^\s*cd\s+("\$(\{S\}|S)"|\$(\{S\}|S))\s')
 
 	def __init__(self, contents):
 		ContentCheck.__init__(self, contents)