From: Tomi Ollila Date: Tue, 4 Nov 2014 20:33:22 +0000 (+0200) Subject: Re: [PATCH v2 00/10] "notmuch address" command X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=39a6574570a1c2c7a2e800f89ed7c0289b1766e2;p=notmuch-archives.git Re: [PATCH v2 00/10] "notmuch address" command --- diff --git a/e0/9aeda2b61830ec06b3fada25567f311f5ae390 b/e0/9aeda2b61830ec06b3fada25567f311f5ae390 new file mode 100644 index 000000000..12b05f7fc --- /dev/null +++ b/e0/9aeda2b61830ec06b3fada25567f311f5ae390 @@ -0,0 +1,128 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 24D60431FCF + for ; Tue, 4 Nov 2014 12:33:59 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 2H0vxpJpJARn for ; + Tue, 4 Nov 2014 12:33:51 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 4942E431FAE + for ; Tue, 4 Nov 2014 12:33:51 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 8A3AB100033; + Tue, 4 Nov 2014 22:33:22 +0200 (EET) +From: Tomi Ollila +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 00/10] "notmuch address" command +In-Reply-To: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz> +References: <1415058622-21162-1-git-send-email-sojkam1@fel.cvut.cz> +User-Agent: Notmuch/0.18.2+169~g5bcdd1c (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 04 Nov 2014 20:34:00 -0000 + +On Tue, Nov 04 2014, Michal Sojka wrote: + +> Hi all, +> +> this is v2 of "notmuch address" patchset. It obsoletes [1]. +> +> Don't be scared by the number of patches. Most of them are trivial +> refactoring. Patches 1-4 refactor the code so that "notmuch search" +> command is easier to split. Patch 5 is Jani's hierarchical command +> line parsing patch. Patch 6 splits search functionality to new address +> command. Patch 7 is minor refactoring. Patches 8-10 correspond to +> patches 5-7 in the original "notmuch search +> --output=sender/recipients" patch series [2]. + +Haven't got time to test these (will do tomorrow). Feature-wise I support +having patches 1-9 applied now(*). (and leave 10 to be bikeshedded post +0.19) + +Tomi + +(*) while testing currennt HEAD i found nomuc cearch --output=sender +date:1d.. | uniq useful, have to see how to have this later... + +(Sent using N9) + +> +> Changes from v1: +> +> - Rebased to current master (conflicted with Jani's "notmuch search +> --duplicate=N with --output=messages" patch) +> - Fixed printing of false "Unrecognized option" error message in +> hierarchical command line parser. +> +> Regards, +> -Michal +> +> [1] id:1414889400-30977-1-git-send-email-sojkam1@fel.cvut.cz +> [2] id:1414792441-29555-1-git-send-email-sojkam1@fel.cvut.cz +> +> +> Jani Nikula (1): +> cli: add support for hierarchical command line option arrays +> +> Michal Sojka (9): +> cli: search: Rename options to context +> cli: search: Move more variables into search_context_t +> cli: search: Convert ctx. to ctx-> +> cli: search: Split notmuch_search_command to smaller functions +> cli: Introduce "notmuch address" command +> cli: search: Convert --output to keyword argument +> cli: address: Do not output duplicate addresses +> cli: address: Add --output=count +> cli: address: Add --filter-by option to configure address filtering +> +> command-line-arguments.c | 16 +- +> command-line-arguments.h | 1 + +> completion/notmuch-completion.bash | 48 +++- +> completion/notmuch-completion.zsh | 11 +- +> doc/man1/notmuch-address.rst | 140 ++++++++++++ +> doc/man1/notmuch-search.rst | 21 +- +> doc/man1/notmuch.rst | 7 +- +> notmuch-client.h | 3 + +> notmuch-search.c | 454 +++++++++++++++++++++++++------------ +> notmuch.c | 2 + +> test/T095-address.sh | 148 ++++++++++++ +> test/T097-address-filter-by.sh | 73 ++++++ +> 12 files changed, 751 insertions(+), 173 deletions(-) +> create mode 100644 doc/man1/notmuch-address.rst +> create mode 100755 test/T095-address.sh +> create mode 100755 test/T097-address-filter-by.sh +> +> -- +> 2.1.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch