From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 14 Feb 2013 18:29:23 +0000 (-0800)
Subject: Merge branch 'jk/error-const-return'
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=393b7c3cd7c87a42e2e477de38d4a6e4981db8bb;p=git.git

Merge branch 'jk/error-const-return'

* jk/error-const-return:
  Use __VA_ARGS__ for all of error's arguments
---

393b7c3cd7c87a42e2e477de38d4a6e4981db8bb
diff --cc git-compat-util.h
index cc2abeea0,89fdf0561..b7eaaa99a
--- a/git-compat-util.h
+++ b/git-compat-util.h
@@@ -305,13 -290,13 +305,13 @@@ extern void warning(const char *err, ..
  
  /*
   * Let callers be aware of the constant return value; this can help
-  * gcc with -Wuninitialized analysis. We have to restrict this trick to
-  * gcc, though, because of the variadic macro and the magic ## comma pasting
-  * behavior. But since we're only trying to help gcc, anyway, it's OK; other
-  * compilers will fall back to using the function as usual.
+  * gcc with -Wuninitialized analysis. We restrict this trick to gcc, though,
+  * because some compilers may not support variadic macros. Since we're only
+  * trying to help gcc, anyway, it's OK; other compilers will fall back to
+  * using the function as usual.
   */
 -#ifdef __GNUC__
 +#if defined(__GNUC__) && ! defined(__clang__)
- #define error(fmt, ...) (error((fmt), ##__VA_ARGS__), -1)
+ #define error(...) (error(__VA_ARGS__), -1)
  #endif
  
  extern void set_die_routine(NORETURN_PTR void (*routine)(const char *err, va_list params));