From: Mark Walters Date: Sun, 9 Feb 2014 10:17:14 +0000 (+0000) Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=38dd77cd84ea4b4e3e4e15fc5ee087677fbe9075;p=notmuch-archives.git Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for part buttons --- diff --git a/2f/f857fc83d38543ebdf2bc4f2afe850b820fcfb b/2f/f857fc83d38543ebdf2bc4f2afe850b820fcfb new file mode 100644 index 000000000..7aa5884aa --- /dev/null +++ b/2f/f857fc83d38543ebdf2bc4f2afe850b820fcfb @@ -0,0 +1,145 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 3D619431FBF + for ; Sun, 9 Feb 2014 02:17:34 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id q6CHW+JpeGBV for ; + Sun, 9 Feb 2014 02:17:28 -0800 (PST) +Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 0CA1D431FBD + for ; Sun, 9 Feb 2014 02:17:28 -0800 (PST) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail1.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WCRRr-0002IS-U1; Sun, 09 Feb 2014 10:17:21 +0000 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WCRRr-0000CT-Jr; Sun, 09 Feb 2014 10:17:15 +0000 +From: Mark Walters +To: "W. Trevor King" +Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for + part buttons +In-Reply-To: <20140208173333.GC17142@odin.tremily.us> +References: <877g9chbay.fsf@qmul.ac.uk> + + <27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us> + <87vbwwosuw.fsf@qmul.ac.uk> <20140203203418.GO14197@odin.tremily.us> + <20140208173333.GC17142@odin.tremily.us> +User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 09 Feb 2014 10:17:14 +0000 +Message-ID: <8761ood1zp.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 93d7d7ccd5b3b0b9f479085e3c370da9 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 09 Feb 2014 10:17:34 -0000 + +On Sat, 08 Feb 2014, "W. Trevor King" wrote: + +> On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote: +>> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote: +>> > My only other comment on the series is that you should update +>> > devel/schemata in the first patch to reflect this addition. +>>=20 +>> Ah, I didn't realize that file existed :p. +> +> Looking at this more, I'm unsure about whether or not I should bump +> the version. b96ba63 (show: indicate length, encoding of omitted body +> content, 2012-12-16) added part.content-length? and +> part.content-transfer-encoding? and doesn't bump the version, while +> abeac48 (search: Add stable queries to thread search results, +> 2013-10-24) adds thread_summary.query and does bump the version. From +> notmuch-client.h: +> +> Backwards-incompatible changes such as removing map fields, changing +> the meaning of map fields, or changing the meanings of list elements +> should increase this. New (required) map fields can be added without +> increasing this. +> +> I think that the addition of part.content-description? should not bump +> the version, but then I'm not sure how to document the change in +> devel/schemata. I'm leaning towards something like: + +I think you just add the new field to the list of fields in the schemata +in the appropriate place in the part section as + +content-description?: string, + +and you don't need to bump the version. I think this is because a client +can safely ask for this field regardless of the notmuch version and +won't get confused.=20 + +Best wishes + +Mark + + + + +> +> diff --git a/devel/schemata b/devel/schemata +> index 41dc4a6..63d8aa4 100644 +> --- a/devel/schemata +> +++ b/devel/schemata +> @@ -26,6 +26,9 @@ v1 +> v2 +> - Added the thread_summary.query field. +> +> +Staged for v3 +> +- Added the part.content-descrition? field. +> + +> Common non-terminals +> -------------------- +> =E2=80=A6 +> +> Alternatively, there could be a minor version that gets bumped on each +> tweak, however insignificant. +> +> Thoughts? +> +> Trevor +> +> --=20 +> This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +> For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy