From: Marcus Brinkmann <mb@g10code.com>
Date: Tue, 23 Mar 2004 18:10:13 +0000 (+0000)
Subject: 2004-03-23  Marcus Brinkmann  <marcus@g10code.de>
X-Git-Tag: gpgme-0-4-6~11
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3816adb43a110bb00e84b985f45a35ed2ab03b24;p=gpgme.git

2004-03-23  Marcus Brinkmann  <marcus@g10code.de>

	* engine-gpgsm.c (gpgsm_new): Protect _only_ tty related code with
	isatty().  Submitted by Bernhard Herzog.
---

diff --git a/gpgme/ChangeLog b/gpgme/ChangeLog
index 7858677..9e52ee8 100644
--- a/gpgme/ChangeLog
+++ b/gpgme/ChangeLog
@@ -1,3 +1,8 @@
+2004-03-23  Marcus Brinkmann  <marcus@g10code.de>
+
+	* engine-gpgsm.c (gpgsm_new): Protect _only_ tty related code with
+	isatty().  Submitted by Bernhard Herzog.
+
 2004-03-11  Marcus Brinkmann  <marcus@g10code.de>
 
 	* engine-gpgsm.c (gpgsm_new): Protect all tty related code with
diff --git a/gpgme/engine-gpgsm.c b/gpgme/engine-gpgsm.c
index 291af9b..929b98c 100644
--- a/gpgme/engine-gpgsm.c
+++ b/gpgme/engine-gpgsm.c
@@ -490,40 +490,40 @@ gpgsm_new (void **engine, const char *lc_ctype, const char *lc_messages)
 		  goto leave;
 		}
 	    }
+	}
+    }
 
-	  if (lc_ctype)
-	    {
-	      if (asprintf (&optstr, "OPTION lc-ctype=%s", lc_ctype) < 0)
-		err = gpg_error_from_errno (errno);
-	      else
-		{
-		  err = assuan_transact (gpgsm->assuan_ctx, optstr, NULL, NULL,
-					 NULL, NULL, NULL, NULL);
-		  free (optstr);
-		  if (err)
-		    err = map_assuan_error (err);
-		}
-	    }
+  if (lc_ctype)
+    {
+      if (asprintf (&optstr, "OPTION lc-ctype=%s", lc_ctype) < 0)
+	err = gpg_error_from_errno (errno);
+      else
+	{
+	  err = assuan_transact (gpgsm->assuan_ctx, optstr, NULL, NULL,
+				 NULL, NULL, NULL, NULL);
+	  free (optstr);
 	  if (err)
-	    goto leave;
-
-	  if (lc_messages)
-	    {
-	      if (asprintf (&optstr, "OPTION lc-messages=%s", lc_messages) < 0)
-		err = gpg_error_from_errno (errno);
-	      else
-		{
-		  err = assuan_transact (gpgsm->assuan_ctx, optstr, NULL, NULL,
-					 NULL, NULL, NULL, NULL);
-		  free (optstr);
-		  if (err)
-		    err = map_assuan_error (err);
-		}
-	    }
+	    err = map_assuan_error (err);
+	}
+    }
+  if (err)
+    goto leave;
+  
+  if (lc_messages)
+    {
+      if (asprintf (&optstr, "OPTION lc-messages=%s", lc_messages) < 0)
+	err = gpg_error_from_errno (errno);
+      else
+	{
+	  err = assuan_transact (gpgsm->assuan_ctx, optstr, NULL, NULL,
+				 NULL, NULL, NULL, NULL);
+	  free (optstr);
 	  if (err)
-	    goto leave;
+	    err = map_assuan_error (err);
 	}
     }
+  if (err)
+    goto leave;
 
   if (!err
       && (_gpgme_io_set_close_notify (gpgsm->status_cb.fd,