From: David Bremner Date: Mon, 4 Aug 2014 23:00:41 +0000 (+2100) Subject: Re: [PATCH v2 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=36e53ee7f6a7a818b11333747754b534292f4849;p=notmuch-archives.git Re: [PATCH v2 1/2] emacs: Introduce notmuch-jump: shortcut keys to saved searches --- diff --git a/bf/9f6b235f241d354c18addd039f68b1f9f88c9b b/bf/9f6b235f241d354c18addd039f68b1f9f88c9b new file mode 100644 index 000000000..18d72655f --- /dev/null +++ b/bf/9f6b235f241d354c18addd039f68b1f9f88c9b @@ -0,0 +1,82 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 122D7431FBC + for ; Mon, 4 Aug 2014 16:00:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9T6bO4vPa7BI for ; + Mon, 4 Aug 2014 16:00:48 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id F25E2431FAE + for ; Mon, 4 Aug 2014 16:00:47 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1XERFG-0008Ux-K2; Mon, 04 Aug 2014 20:00:46 -0300 +Received: (nullmailer pid 24145 invoked by uid 1000); Mon, 04 Aug 2014 + 23:00:41 -0000 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 1/2] emacs: Introduce notmuch-jump: shortcut keys to + saved searches +In-Reply-To: <1405433166-2198-2-git-send-email-amdragon@mit.edu> +References: <1405353735-26244-1-git-send-email-amdragon@mit.edu> + <1405433166-2198-1-git-send-email-amdragon@mit.edu> + <1405433166-2198-2-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.18.1+45~gf47eeac (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 04 Aug 2014 20:00:41 -0300 +Message-ID: <87ha1r6esm.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 04 Aug 2014 23:00:52 -0000 + +Austin Clements writes: + +> This introduces notmuch-jump, which is like a user-friendly, +> user-configurable global prefix map for saved searches. This provi + +Unfortunately this patch doesn't apply anymore. + +> @@ -18,7 +18,8 @@ emacs_sources := \ +> $(dir)/notmuch-tag.el \ +> $(dir)/coolj.el \ +> $(dir)/notmuch-print.el \ +> - $(dir)/notmuch-version.el +> + $(dir)/notmuch-version.el \ +> + $(dir)/notmuch-jump.el \ + +Why the extra \ ? + +> +(defun notmuch-jump--plist-delete (plist property) +> + (let* ((xplist (cons nil plist)) +> + (pred xplist)) +> + (while (cdr pred) +> + (when (eq (cadr pred) property) +> + (setcdr pred (cdddr pred))) +> + (setq pred (cddr pred))) +> + (cdr xplist))) + +Should this function maybe be somewhere more generic? +