From: Shawn O. Pearce <spearce@spearce.org>
Date: Thu, 21 Feb 2008 02:55:43 +0000 (-0500)
Subject: git-gui: Only bind the spellcheck popup suggestion hook once
X-Git-Tag: v1.5.5-rc0~3^2~23
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=35d04b3b110f9adcd485c8470d8048394f586018;p=git.git

git-gui: Only bind the spellcheck popup suggestion hook once

If we reconnect to the spellchecker there is no reason to resetup
the binding for button 3 on our text widget to show the suggestion
list (if available).

Plus, by moving it out of _connect and into init we can now break
out of _connect earlier if there is something wrong with the pipe,
for example if the dictionary we were asked to load is not valid.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---

diff --git a/lib/spellcheck.tcl b/lib/spellcheck.tcl
index f359356c8..a37ff5f8f 100644
--- a/lib/spellcheck.tcl
+++ b/lib/spellcheck.tcl
@@ -23,6 +23,7 @@ constructor init {pipe_fd ui_text ui_menu} {
 	set w_menu $ui_menu
 	array unset s_suggest
 
+	bind_button3 $w_text [cb _popup_suggest %X %Y @%x,%y]
 	_connect $this $pipe_fd
 	return $this
 }
@@ -66,7 +67,6 @@ method _connect {pipe_fd} {
 	$w_text tag conf misspelled \
 		-foreground red \
 		-underline 1
-	bind_button3 $w_text [cb _popup_suggest %X %Y @%x,%y]
 
 	array unset s_suggest
 	set s_seen    [list]