From: David Bremner Date: Sat, 22 Feb 2014 01:21:36 +0000 (+2000) Subject: Re: [PATCH] emacs: Avoid rebuilding .eldeps even when there's nothing to do X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=35abeaa1f83a42993a0f167f7eeb9e26c931310b;p=notmuch-archives.git Re: [PATCH] emacs: Avoid rebuilding .eldeps even when there's nothing to do --- diff --git a/3e/1f3a222f271054bb9dd0b8f6be4938f4857bec b/3e/1f3a222f271054bb9dd0b8f6be4938f4857bec new file mode 100644 index 000000000..af46af8be --- /dev/null +++ b/3e/1f3a222f271054bb9dd0b8f6be4938f4857bec @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 17E15431FC3 + for ; Fri, 21 Feb 2014 17:21:48 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id DdKHJKRUSdIX for ; + Fri, 21 Feb 2014 17:21:44 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 38D92431FBD + for ; Fri, 21 Feb 2014 17:21:41 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WH1Hg-0007vw-0H; Fri, 21 Feb 2014 21:21:40 -0400 +Received: (nullmailer pid 31333 invoked by uid 1000); Sat, 22 Feb 2014 + 01:21:36 -0000 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: Avoid rebuilding .eldeps even when there's + nothing to do +In-Reply-To: <1392870264-11156-1-git-send-email-amdragon@mit.edu> +References: + <1392870264-11156-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Fri, 21 Feb 2014 21:21:36 -0400 +Message-ID: <878ut4x7q7.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 22 Feb 2014 01:21:48 -0000 + +Austin Clements writes: + +> Previously, we updated .eldeps only if the file contents actually +> needed to change. This was done to avoid unnecessary make restarts +> (if the .eldeps rule changes the mtime of .eldeps, make has to restart +> to collect the new dependencies). However, this meant that, after a +> modification to any .el file that did not change dependencies, .eldeps +> would always be out of date, so every make invocation would run the +> .eldeps rule, which is both expensive because it starts up Emacs and +> noisy. This was true even when there was nothing to do. E.g., +> + +pushed. + +d