From: Ken Raeburn <raeburn@mit.edu>
Date: Wed, 6 Aug 2008 00:05:47 +0000 (+0000)
Subject: fix cleanup code in allocating preauth info
X-Git-Tag: krb5-1.7-alpha1~536
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=34f627f9858cd944d2f1f04eac15bae011d55fe0;p=krb5.git

fix cleanup code in allocating preauth info

After an allocation failure, free up the previously allocated array
elements by counting back down to zero, not continuing to count up
until we hit zero.

ticket: new
target_version: 1.6.4
tags: pullup

git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@20608 dc483132-0cff-0310-8789-dd5450dbe970
---

diff --git a/src/lib/krb5/krb/get_in_tkt.c b/src/lib/krb5/krb/get_in_tkt.c
index a993870ce..36b731155 100644
--- a/src/lib/krb5/krb/get_in_tkt.c
+++ b/src/lib/krb5/krb/get_in_tkt.c
@@ -1,7 +1,7 @@
 /*
  * lib/krb5/krb/get_in_tkt.c
  *
- * Copyright 1990,1991, 2003 by the Massachusetts Institute of Technology.
+ * Copyright 1990,1991, 2003, 2008 by the Massachusetts Institute of Technology.
  * All Rights Reserved.
  *
  * Export of this software from the United States of America may
@@ -454,7 +454,7 @@ make_preauth_list(krb5_context	context,
     for (i=0; i<nptypes; i++) {
  	if ((preauthp[i] =
  	     (krb5_pa_data *) malloc(sizeof(krb5_pa_data))) == NULL) {
- 	    for (; i>=0; i++)
+ 	    for (; i>=0; i--)
  		free(preauthp[i]);
  	    free(preauthp);
 	    return (ENOMEM);