From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Thu, 20 Mar 2014 10:29:27 +0000 (+0200)
Subject: Re: out of tree build fixes
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=33cced9891c5452f32fe32e2b100b677b0e99f16;p=notmuch-archives.git

Re: out of tree build fixes
---

diff --git a/f6/4ae6501342fcb633febe20541dd4ede4e2d082 b/f6/4ae6501342fcb633febe20541dd4ede4e2d082
new file mode 100644
index 000000000..1dc313d55
--- /dev/null
+++ b/f6/4ae6501342fcb633febe20541dd4ede4e2d082
@@ -0,0 +1,75 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 1E0C1431FAF
+	for <notmuch@notmuchmail.org>; Thu, 20 Mar 2014 03:29:44 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id s4NX0UHkDiZN for <notmuch@notmuchmail.org>;
+	Thu, 20 Mar 2014 03:29:36 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id E3C32431FAE
+	for <notmuch@notmuchmail.org>; Thu, 20 Mar 2014 03:29:35 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id E136D10009D;
+	Thu, 20 Mar 2014 12:29:27 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: out of tree build fixes
+In-Reply-To: <1395276484-22363-1-git-send-email-david@tethera.net>
+References: <1395276484-22363-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.17+155~g3416ef5 (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Thu, 20 Mar 2014 12:29:27 +0200
+Message-ID: <m2d2hhduyg.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Thu, 20 Mar 2014 10:29:44 -0000
+
+On Thu, Mar 20 2014, David Bremner <david@tethera.net> wrote:
+
+> Apparently we've neglected the out of tree builds even more than
+> usual. I originally thought this is what was causing the test failures
+> on buildbot. I'm less sure now, but I think these fixes don't hurt
+> anything, and they do unbreak out of tree builds for me.
+>
+> There is certainly still work to be done with our out of tree builds.
+> For those of you just joining the party, that doesn't mean we want to
+> switch to your favourite build system. Or even to Autotools.
+>
+> An earlier draft of this series (discussed on IRC) defined a builddir
+> variable, but eventually I realized the current directory of make is
+> always builddir. So at least for now that doesn't seem to be needed.
+
+LGTM. Too bad we cannot expand $(dir) in recipes (or I don't know how),
+and using other variables don't bring any benefit (naming would contain
+the 'doc' part and we even cannot check whether the variable is defined
+or not...).
+
+>
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch