From: David Edmondson Date: Fri, 16 May 2014 11:13:45 +0000 (+0100) Subject: Re: [PATCH v2] Enable Travis-CI as a backup continuous integration service. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=33ca12b35a632782924f0465fa97574b599a5e32;p=notmuch-archives.git Re: [PATCH v2] Enable Travis-CI as a backup continuous integration service. --- diff --git a/0e/2b61a8d9bb0e46ce2c011e50290e9ee4320bbb b/0e/2b61a8d9bb0e46ce2c011e50290e9ee4320bbb new file mode 100644 index 000000000..8685f63eb --- /dev/null +++ b/0e/2b61a8d9bb0e46ce2c011e50290e9ee4320bbb @@ -0,0 +1,119 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1E3C6431FBC + for ; Fri, 16 May 2014 04:14:01 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id SraJsMGm6ayL for ; + Fri, 16 May 2014 04:13:57 -0700 (PDT) +Received: from mail-we0-f177.google.com (mail-we0-f177.google.com + [74.125.82.177]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id BC8C6431FAE + for ; Fri, 16 May 2014 04:13:56 -0700 (PDT) +Received: by mail-we0-f177.google.com with SMTP id x48so2368156wes.22 + for ; Fri, 16 May 2014 04:13:55 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:cc:subject:in-reply-to:references:user-agent + :from:date:message-id:mime-version:content-type; + bh=zoUkeQS3q9M0wcMTK5SkhkjZZBgTEN4Tsi292QUzvmQ=; + b=OT4SOwY1SFz1VsERqfgSbqa5l+3nqFI61aJ4NBn90hQUHKeFWjs4LG1bPdnnDHanmH + WVFa8cbzzmqUYU0/TiYzS/dobl2jW/rCPJRHN0/NzCHt42LzeJwatYuHlBsYWkhDDYsg + L7Yi4HifoxDCuquWWT46IHrTT5l9heHsjnHIfHBO02n/84xHpsbep1Ae9Junro+9U64w + ZaGwty4neNs7fAysGn1+zMOCVpOWDeqGnRj+1lAONv8meVq93mAZLnxEJg2nDCNlmv4u + njWnOVVUjQf3gyk1JGpPrmaBEn7zMs2yTqBANhM/JAjpMv8gGgCAG+kBO5zG05ek5NnJ + Ei+g== +X-Gm-Message-State: + ALoCoQkp5YceCNWYspRlw8dkmB+YHjJ2+zEq7U7wTbAkjWP/sh4zsXfyEjSFUnMQwdmevk2iMj7H +X-Received: by 10.194.157.68 with SMTP id wk4mr13371130wjb.42.1400238835461; + Fri, 16 May 2014 04:13:55 -0700 (PDT) +Received: from localhost ([2a01:348:1a2:1:a288:b4ff:fe8a:77d8]) + by mx.google.com with ESMTPSA id em5sm2798043wic.23.2014.05.16.04.13.50 + for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Fri, 16 May 2014 04:13:51 -0700 (PDT) +To: "W. Trevor King" , + Wael Nasreddine +Subject: Re: [PATCH v2] Enable Travis-CI as a backup continuous integration + service. +In-Reply-To: <20140515190445.GS11834@odin.tremily.us> +References: <1400108004-26955-1-git-send-email-wael.nasreddine@gmail.com> + <1400108004-26955-2-git-send-email-wael.nasreddine@gmail.com> + + + <20140515190445.GS11834@odin.tremily.us> +User-Agent: Notmuch/0.18 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Fri, 16 May 2014 12:13:45 +0100 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 16 May 2014 11:14:01 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Thu, May 15 2014, W. Trevor King wrote: +> On Thu, May 15, 2014 at 10:40:06AM -0700, Wael Nasreddine wrote: +>> David Edmondson writes: +>> > I realise that you might answer "I will keep this up to date", but +>> > we have to worry about what happens if you lose interest and +>> > wander away. +>>=20 +>> Absolutely, I understand your point and no one can guarantee +>> maintainer-ship. I can modify my patch and add documentation +>> (comments in the yaml file) about what each flag does, where can you +>> documentation about it and of course details about the hack. Would +>> that be helpful? +> +> I personally love comments like this, but I prefer them in the commit +> message. Otherwise the source becomes one humongous comment with a +> bit of interspersed code ;). An interactive blame (like you get with +> tig [1] and probably any interactive Git frontent) makes these +> commit-messages easily accessible (assuming they're not buried under +> whitespace churn, etc.) + +I disagree. In this case, the comments explain the code, so they belong +in the code. + +When the version number of zlib we have to download changes, that's the +type of comment that belongs in the commit message. + +--=-=-= +Content-Type: application/pgp-signature; name="signature.asc" + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1 + +iKYEARECAGYFAlN18ulfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl +bnBncC5maWZ0aGhvcnNlbWFuLm5ldDc1M0Y5NDJDMEExNjc3MDE4OURGMUYyMDY5 +RUNEMEFCRjA0OTY1MTYACgkQaezQq/BJZRY0dQCfV4E9blNnHKedJ0kM9/bGcD5n +QFAAn3WlIwNX8RzTCVKaNmmebsWJdEnJ +=cUsb +-----END PGP SIGNATURE----- +--=-=-=--