From: David Bremner <david@tethera.net>
Date: Fri, 6 Sep 2013 01:22:42 +0000 (+2100)
Subject: Re: segfault with xapian 1.3.1
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=33108a3bf914be0d90c312a1d18e5bba53a41999;p=notmuch-archives.git

Re: segfault with xapian 1.3.1
---

diff --git a/67/0457bee51b40afdad612396e6f92a085a5227c b/67/0457bee51b40afdad612396e6f92a085a5227c
new file mode 100644
index 000000000..7b54220e5
--- /dev/null
+++ b/67/0457bee51b40afdad612396e6f92a085a5227c
@@ -0,0 +1,74 @@
+Return-Path: <david@tethera.net>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id 401CE431E82
+	for <notmuch@notmuchmail.org>; Thu,  5 Sep 2013 18:22:54 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id avykhd6HQh2y for <notmuch@notmuchmail.org>;
+	Thu,  5 Sep 2013 18:22:50 -0700 (PDT)
+Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
+	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
+	(No client certificate requested)
+	by olra.theworths.org (Postfix) with ESMTPS id F09ED431E62
+	for <notmuch@notmuchmail.org>; Thu,  5 Sep 2013 18:22:49 -0700 (PDT)
+Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
+	(envelope-from <david@tethera.net>)
+	id 1VHkl5-0001xc-91; Thu, 05 Sep 2013 22:22:47 -0300
+Received: (nullmailer pid 4013 invoked by uid 1000); Fri, 06 Sep 2013
+	01:22:42 -0000
+From: David Bremner <david@tethera.net>
+To: "Jason A. Donenfeld" <Jason@zx2c4.com>, notmuch ML
+	<notmuch@notmuchmail.org>
+Subject: Re: segfault with xapian 1.3.1
+In-Reply-To: <87txhypzvz.fsf@zancas.localnet>
+References:
+ <CAHmME9q3H2KKBRb_VU4Rr-pc+2qR=uPxiX8YPBFE4N0DaiidAA@mail.gmail.com>
+	<87txhypzvz.fsf@zancas.localnet>
+User-Agent: Notmuch/0.16+37~g9701e9c (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-pc-linux-gnu)
+Date: Thu, 05 Sep 2013 22:22:42 -0300
+Message-ID: <87r4d2pwv1.fsf@zancas.localnet>
+MIME-Version: 1.0
+Content-Type: text/plain
+Cc: Olly Betts <olly@survex.com>
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 06 Sep 2013 01:22:54 -0000
+
+David Bremner <david@tethera.net> writes:
+
+>
+> I managed to duplicate this problem on Debian testing by rebuilding
+> Olly's packages (https://launchpad.net/~ojwb/+archive/xapian-1.3) for
+> sid and running the following script in the ./test subdirectory
+
+Olly wrote on  IRC:
+
+> bremner: ok, 1.2 explicitly no-oped skip_to() on an iterator at_end on
+> trunk that code has been rewritten without that explicit check, and
+> the iterator internals are NULL then i think restoring the check is
+> reasonable, though I'm not sure if we actually promise that's defined
+> behaviour if you want to work with 1.3.1, then checking against the
+> end iterator before calling skip_to() will work for any version
+
+So, now we know what to fix.
+
+d