From: Felipe Contreras Date: Sat, 13 Apr 2013 06:49:23 +0000 (+1900) Subject: Re: [PATCH] debian: package ruby bindings X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=32a90154924d8c5d61276e73dc6694923a35bc05;p=notmuch-archives.git Re: [PATCH] debian: package ruby bindings --- diff --git a/67/3a354ef1c67f89004b123cef0aae85015c2db0 b/67/3a354ef1c67f89004b123cef0aae85015c2db0 new file mode 100644 index 000000000..9b48cc005 --- /dev/null +++ b/67/3a354ef1c67f89004b123cef0aae85015c2db0 @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id C7718431FAF + for ; Fri, 12 Apr 2013 23:49:25 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OZvSu522ojh1 for ; + Fri, 12 Apr 2013 23:49:25 -0700 (PDT) +Received: from mail-la0-f46.google.com (mail-la0-f46.google.com + [209.85.215.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id AE3E4431FAE + for ; Fri, 12 Apr 2013 23:49:24 -0700 (PDT) +Received: by mail-la0-f46.google.com with SMTP id ea20so3112185lab.33 + for ; Fri, 12 Apr 2013 23:49:23 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=mime-version:x-received:in-reply-to:references:date:message-id + :subject:from:to:cc:content-type; + bh=OsFyzvI0oXJ/iXZUeqTAyOQZoD0ODaGGkbQ4jpHmbzc=; + b=aJU2EZ8Scv9GVUk6TofDdE+yJqOzlxrOhUFrAVY/FWS7ADwO0vFrsQxsT/9wa0gFk3 + cTvpU0ddX058uh6FaEsDBx3pqGOEJQL4JxCnnXsjuGRG/V7X307rCz06kz8wIvRbsbe1 + GC4fNtuSixaUjaG39n/wcqaH757YPi6i4yrrkRB1ZeCUd1KPnxPOksUaTVSqOr02rebJ + bs1CdZVjdv8ZxXcxZ9pyhvA9T70V8sLCL9zpQ8lSohpIWaVumMUF0M6H7MnLV5F7B12y + j3JwQNtvBcBB10U8yDa6RY3Shwe3DbwiQHPFQ+nx8+q3GiKVsg30g8FKCP20FRiMDByQ + 38pw== +MIME-Version: 1.0 +X-Received: by 10.112.133.198 with SMTP id pe6mr6646713lbb.103.1365835763235; + Fri, 12 Apr 2013 23:49:23 -0700 (PDT) +Received: by 10.114.59.210 with HTTP; Fri, 12 Apr 2013 23:49:23 -0700 (PDT) +In-Reply-To: +References: <1365031678-25188-1-git-send-email-felipe.contreras@gmail.com> + + +Date: Sat, 13 Apr 2013 01:49:23 -0500 +Message-ID: + +Subject: Re: [PATCH] debian: package ruby bindings +From: Felipe Contreras +To: Tomi Ollila +Content-Type: text/plain; charset=UTF-8 +Cc: notmuch@notmuchmail.org, David Bremner , + Stefano Zacchiroli +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 13 Apr 2013 06:49:25 -0000 + +On Sat, Apr 13, 2013 at 1:14 AM, Tomi Ollila wrote: +> On Sat, Apr 13 2013, Felipe Contreras wrote: +> +>> On Wed, Apr 3, 2013 at 5:27 PM, Felipe Contreras +>> wrote: +>>> Signed-off-by: Felipe Contreras +>>> --- +>>> debian/control | 14 ++++++++++++++ +>>> debian/notmuch-ruby.install | 1 + +>>> debian/rules | 9 +++++++++ +>>> 3 files changed, 24 insertions(+) +>>> create mode 100644 debian/notmuch-ruby.install +>> +>> No comments? Should I push this? +> +> How do we ensure that ruby package is working in every release; +> there seems to be no tests for it ? + +We probably should have tests, but how is that relevant to this patch? +The code is already there, and distributions are already shipping it: + +https://projects.archlinux.org/svntogit/community.git/plain/trunk/PKGBUILD?h=packages/notmuch + +If there's reason to be worried about shipping something that doesn't +work, too late, we are already shipping it. And that's orthogonal to +this patch, shouldn't prevent it to be merged. + +Cheers. + +-- +Felipe Contreras