From: Zac Medico <zmedico@gentoo.org>
Date: Fri, 4 Feb 2011 17:41:30 +0000 (-0800)
Subject: depgraph: make downgrades trigger complete graph
X-Git-Tag: v2.1.9.36~7
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=320df213972f7ce50e7f2379a3a0d7d0bbbef051;p=portage.git

depgraph: make downgrades trigger complete graph

It's common for downgrades to break dependencies, as in bug #353613, so
automatically trigger complete graph mode when a downgrade is found.
---

diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index 5380de15b..7b74a265e 100644
--- a/pym/_emerge/depgraph.py
+++ b/pym/_emerge/depgraph.py
@@ -3408,8 +3408,27 @@ class depgraph(object):
 			return 1
 
 		if "complete" not in self._dynamic_config.myparams:
-			# Skip this to avoid consuming enough time to disturb users.
-			return 1
+			# Automatically enable complete mode if there are any
+			# downgrades, since they often break dependencies
+			# (like in bug #353613).
+			have_downgrade = False
+			for node in self._dynamic_config.digraph:
+				if not isinstance(node, Package) or \
+					node.operation != "merge":
+					continue
+				vardb = self._frozen_config.roots[
+					node.root].trees["vartree"].dbapi
+				inst_pkg = vardb.match_pkgs(node.slot_atom)
+				if inst_pkg and inst_pkg[0] > node:
+					have_downgrade = True
+					break
+
+			if have_downgrade:
+				self._dynamic_config.myparams["complete"] = True
+			else:
+				# Skip complete graph mode, in order to avoid consuming
+				# enough time to disturb users.
+				return 1
 
 		self._load_vdb()