From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Fri, 24 Jan 2014 18:43:52 +0000 (+0200)
Subject: Re: Round 2: fix for notmuch show segfault
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=31bbf0424765c688c98a7e1e068cbe7907f854d1;p=notmuch-archives.git

Re: Round 2: fix for notmuch show segfault
---

diff --git a/2d/4a738fb1cb04c92bdbfbfda88b5d04e0853dfe b/2d/4a738fb1cb04c92bdbfbfda88b5d04e0853dfe
new file mode 100644
index 000000000..1d931b7b6
--- /dev/null
+++ b/2d/4a738fb1cb04c92bdbfbfda88b5d04e0853dfe
@@ -0,0 +1,84 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+	by olra.theworths.org (Postfix) with ESMTP id E1B09431FBC
+	for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 10:44:03 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
+X-Spam-Flag: NO
+X-Spam-Score: 0
+X-Spam-Level: 
+X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
+	autolearn=disabled
+Received: from olra.theworths.org ([127.0.0.1])
+	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
+	with ESMTP id eg985ZW+CHq8 for <notmuch@notmuchmail.org>;
+	Fri, 24 Jan 2014 10:43:58 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+	by olra.theworths.org (Postfix) with ESMTP id 677E3431FB6
+	for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 10:43:58 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+	by guru.guru-group.fi (Postfix) with ESMTP id C9ACF1000B3;
+	Fri, 24 Jan 2014 20:43:52 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: Mark Walters <markwalters1009@gmail.com>,
+ David Bremner <david@tethera.net>,	notmuch@notmuchmail.org
+Subject: Re: Round 2: fix for notmuch show segfault
+In-Reply-To: <87a9emzixc.fsf@qmul.ac.uk>
+References: <m2r47zrkkc.fsf@guru.guru-group.fi>
+	<1390479841-17045-1-git-send-email-david@tethera.net>
+	<87a9emzixc.fsf@qmul.ac.uk>
+User-Agent: Notmuch/0.17+41~g8e7fabf (http://notmuchmail.org) Emacs/24.3.1
+	(x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+	!)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Fri, 24 Jan 2014 20:43:52 +0200
+Message-ID: <m21tzxqkyf.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.13
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+	<notmuch.notmuchmail.org>
+List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
+	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Fri, 24 Jan 2014 18:44:04 -0000
+
+On Thu, Jan 23 2014, Mark Walters <markwalters1009@gmail.com> wrote:
+
+> This looks good and works (tested without patch 2/3). I don't have a
+> view on whether we should do the second patch or just update the docs.
+
+Looks good. for patch #2 I'd check which one is more consistent
+with other code constructs used & library interface functions...
+
+Tomi
+
+
+>
+> Best wishes
+>
+> Mark
+>
+>
+>
+> On Thu, 23 Jan 2014, David Bremner <david@tethera.net> wrote:
+>> Second try. The second patch is now not really needed (although I
+>> didn't test without it). If omitted, the library docs should probably
+>> be updated.
+>>
+>> _______________________________________________
+>> notmuch mailing list
+>> notmuch@notmuchmail.org
+>> http://notmuchmail.org/mailman/listinfo/notmuch
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> http://notmuchmail.org/mailman/listinfo/notmuch