From: stevenknight Date: Mon, 26 Sep 2005 04:19:32 +0000 (+0000) Subject: Explicit "skipping test" messages for a few straggling tests. X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3101314aa953e90703d8604155894d8b87d779b6;p=scons.git Explicit "skipping test" messages for a few straggling tests. git-svn-id: http://scons.tigris.org/svn/scons/trunk@1353 fdb21ef1-2011-0410-befe-b5e4ea1792b1 --- diff --git a/etc/TestSCons.py b/etc/TestSCons.py index 520bbfd6..649cf8e7 100644 --- a/etc/TestSCons.py +++ b/etc/TestSCons.py @@ -268,7 +268,11 @@ class TestSCons(TestCommon): # so this is an Aegis invocation; pass the test (exit 0). self.pass_test() else: - self.no_result() + # skip=1 means skip this function when showing where this + # result came from. They only care about the line where the + # script called test.skip_test(), not the line number where + # we call test.no_result(). + self.no_result(skip=1) def java_ENV(self): diff --git a/src/engine/SCons/Tool/msvs.py b/src/engine/SCons/Tool/msvs.py index 7870695f..fb4f1b3a 100644 --- a/src/engine/SCons/Tool/msvs.py +++ b/src/engine/SCons/Tool/msvs.py @@ -143,7 +143,7 @@ class _DSPGenerator: self.source = os.path.abspath(source[0]) else: self.source = source[0].get_abspath() - + self.env = env if self.env.has_key('name'): @@ -193,37 +193,45 @@ class _DSPGenerator: def Build(self): pass - + +V6DSPHeader = """\ +# Microsoft Developer Studio Project File - Name="%(name)s" - Package Owner=<4> +# Microsoft Developer Studio Generated Build File, Format Version 6.00 +# ** DO NOT EDIT ** + +# TARGTYPE "Win32 (x86) External Target" 0x0106 + +CFG=%(name)s - Win32 %(confkey)s +!MESSAGE This is not a valid makefile. To build this project using NMAKE, +!MESSAGE use the Export Makefile command and run +!MESSAGE +!MESSAGE NMAKE /f "%(name)s.mak". +!MESSAGE +!MESSAGE You can specify a configuration when running NMAKE +!MESSAGE by defining the macro CFG on the command line. For example: +!MESSAGE +!MESSAGE NMAKE /f "%(name)s.mak" CFG="%(name)s - Win32 %(confkey)s" +!MESSAGE +!MESSAGE Possible choices for configuration are: +!MESSAGE +""" + class _GenerateV6DSP(_DSPGenerator): """Generates a Project file for MSVS 6.0""" def PrintHeader(self): - name = self.name # pick a default config confkeys = self.configs.keys() confkeys.sort() - self.file.write('# Microsoft Developer Studio Project File - Name="%s" - Package Owner=<4>\n' - '# Microsoft Developer Studio Generated Build File, Format Version 6.00\n' - '# ** DO NOT EDIT **\n\n' - '# TARGTYPE "Win32 (x86) External Target" 0x0106\n\n' - 'CFG=%s - Win32 %s\n' - '!MESSAGE This is not a valid makefile. To build this project using NMAKE,\n' - '!MESSAGE use the Export Makefile command and run\n' - '!MESSAGE \n' - '!MESSAGE NMAKE /f "%s.mak".\n' - '!MESSAGE \n' - '!MESSAGE You can specify a configuration when running NMAKE\n' - '!MESSAGE by defining the macro CFG on the command line. For example:\n' - '!MESSAGE \n' - '!MESSAGE NMAKE /f "%s.mak" CFG="%s - Win32 %s"\n' - '!MESSAGE \n' - '!MESSAGE Possible choices for configuration are:\n' - '!MESSAGE \n' % (name,name,confkeys[0],name,name,name,confkeys[0])) + name = self.name + confkey = confkeys[0] + + self.file.write(V6DSPHeader % locals()) for kind in confkeys: self.file.write('!MESSAGE "%s - Win32 %s" (based on "Win32 (x86) External Target")\n' % (name, kind)) - + self.file.write('!MESSAGE \n\n') def PrintProject(self): @@ -258,13 +266,13 @@ class _GenerateV6DSP(_DSPGenerator): (d,c) = os.path.split(str(self.conspath)) cmd = 'echo Starting SCons && "%s" -c "%s" -C %s -f %s %s' cmd = cmd % (python_executable, exec_script_main, d, c, buildtarget) - self.file.write('# PROP %sCmd_Line "%s"\n' + self.file.write('# PROP %sCmd_Line "%s"\n' '# PROP %sRebuild_Opt "-c && %s"\n' '# PROP %sTarget_File "%s"\n' '# PROP %sBsc_Name ""\n' '# PROP %sTarget_Dir ""\n'\ %(base,cmd,base,cmd,base,buildtarget,base,base)) - + self.file.write('\n!ENDIF\n\n' '# Begin Target\n\n') for kind in confkeys: @@ -281,7 +289,7 @@ class _GenerateV6DSP(_DSPGenerator): self.PrintSourceFiles() self.file.write('# End Target\n' '# End Project\n') - + # now we pickle some data and add it to the file -- MSDEV will ignore it. pdata = pickle.dumps(self.configs,1) pdata = base64.encodestring(pdata) @@ -289,7 +297,7 @@ class _GenerateV6DSP(_DSPGenerator): pdata = pickle.dumps(self.sources,1) pdata = base64.encodestring(pdata) self.file.write(pdata + '\n') - + def PrintSourceFiles(self): categories = {' Source Files': 'cpp|c|cxx|l|y|def|odl|idl|hpj|bat', 'Header Files': 'h|hpp|hxx|hm|inl', @@ -302,11 +310,11 @@ class _GenerateV6DSP(_DSPGenerator): for kind in cats: if not self.sources[kind]: continue # skip empty groups - + self.file.write('# Begin Group "' + kind + '"\n\n') typelist = categories[kind].replace('|',';') self.file.write('# PROP Default_Filter "' + typelist + '"\n') - + for file in self.sources[kind]: file = os.path.normpath(file) self.file.write('# Begin Source File\n\n' @@ -366,7 +374,7 @@ class _GenerateV6DSP(_DSPGenerator): return # unable to unpickle any data for some reason self.sources.update(data) - + def Build(self): try: self.file = open(self.dspfile,'w') @@ -377,6 +385,38 @@ class _GenerateV6DSP(_DSPGenerator): self.PrintProject() self.file.close() +V7DSPHeader = """\ + + +\t +\t\t +\t +""" + +V7DSPConfiguration = """\ +\t\t +\t\t\t +\t\t +""" + class _GenerateV7DSP(_DSPGenerator): """Generates a Project file for MSVS .NET""" @@ -388,59 +428,32 @@ class _GenerateV7DSP(_DSPGenerator): self.versionstr = '7.10' def PrintHeader(self): - self.file.write('\n' - '\n' - ' \n' - ' \n' - ' \n' % (self.versionstr, self.name)) + self.file.write(V7DSPHeader % self.__dict__) def PrintProject(self): - - - self.file.write(' \n') + self.file.write('\t\n') confkeys = self.configs.keys() confkeys.sort() for kind in confkeys: + capitalized_kind = kind.capitalize() outdir = self.configs[kind].outdir buildtarget = self.configs[kind].buildtarget (d,c) = os.path.split(str(self.conspath)) - cmd = 'echo Starting SCons && "%s" -c "%s" -C %s -f %s %s' % (python_executable, - exec_script_main_xml, - d, c, buildtarget) - - cleancmd = 'echo Starting SCons && "%s" -c "%s" -C %s -f %s -c %s' % (python_executable, - exec_script_main_xml, - d, c, buildtarget) - - self.file.write(' \n' - ' \n' - ' \n' % (kind.capitalize(),outdir,outdir,\ - cmd,cleancmd,cmd,buildtarget)) - - self.file.write(' \n') + fmt = 'echo Starting SCons && "%s" -c "%s" -C %s -f %s%s %s' + cmd = fmt % (python_executable, exec_script_main_xml, + d, c, '', buildtarget) + cleancmd = fmt % (python_executable, exec_script_main_xml, + d, c, ' -c', buildtarget) + + self.file.write(V7DSPConfiguration % locals()) + + self.file.write('\t\n') + if self.version >= 7.1: - self.file.write(' \n') - self.file.write(' \n') + self.file.write('\t\n' + '\t\n') self.PrintSourceFiles() @@ -453,7 +466,7 @@ class _GenerateV7DSP(_DSPGenerator): pdata = pickle.dumps(self.sources,1) pdata = base64.encodestring(pdata) self.file.write(pdata + '-->\n') - + def PrintSourceFiles(self): categories = {' Source Files': 'cpp;c;cxx;l;y;def;odl;idl;hpj;bat', 'Header Files': 'h;hpp;hxx;hm;inl', @@ -461,33 +474,34 @@ class _GenerateV7DSP(_DSPGenerator): 'Resource Files': 'r;rc;ico;cur;bmp;dlg;rc2;rct;bin;cnt;rtf;gif;jpg;jpeg;jpe', 'Other Files': ''} - self.file.write(' \n') - + self.file.write('\t\n') + cats = categories.keys() cats.sort() for kind in cats: if not self.sources[kind]: continue # skip empty groups - self.file.write(' \n' % (kind, categories[kind])) - + self.file.write('\t\t\n' % (kind, categories[kind])) + for file in self.sources[kind]: file = os.path.normpath(file) - self.file.write(' \n' - ' \n' % file) + self.file.write('\t\t\t\n' + '\t\t\t\n' % file) - self.file.write(' \n') + self.file.write('\t\t\n') # add the Conscript file outside of the groups - self.file.write(' \n' - ' \n' - ' \n' - ' \n' - ' \n' % str(self.source)) + self.file.write('\t\t\n' + '\t\t\n' + '\t\n' % str(self.source)) + + self.file.write('\t\n' + '\t\n') def Parse(self): try: @@ -535,7 +549,7 @@ class _GenerateV7DSP(_DSPGenerator): return # unable to unpickle any data for some reason self.sources.update(data) - + def Build(self): try: self.file = open(self.dspfile,'w') @@ -627,31 +641,31 @@ class _GenerateV7DSW(_DSWGenerator): 'Project("{8BC9CEB8-8B4A-11D0-8D11-00A0C91BC942}") = "%s", "%s", "%s"\n' % (self.versionstr, self.name, os.path.basename(self.dspfile), self.slnguid)) if self.version >= 7.1: - self.file.write(' ProjectSection(ProjectDependencies) = postProject\n' - ' EndProjectSection\n') + self.file.write('\tProjectSection(ProjectDependencies) = postProject\n' + '\tEndProjectSection\n') self.file.write('EndProject\n' 'Global\n' - ' GlobalSection(SolutionConfiguration) = preSolution\n') + '\tGlobalSection(SolutionConfiguration) = preSolution\n') confkeys = self.configs.keys() confkeys.sort() cnt = 0 for name in confkeys: - self.file.write(' ConfigName.%d = %s\n' % (cnt, name.capitalize())) + self.file.write('\t\tConfigName.%d = %s\n' % (cnt, name.capitalize())) cnt = cnt + 1 - self.file.write(' EndGlobalSection\n') + self.file.write('\tEndGlobalSection\n') if self.version < 7.1: - self.file.write(' GlobalSection(ProjectDependencies) = postSolution\n' - ' EndGlobalSection\n') - self.file.write(' GlobalSection(ProjectConfiguration) = postSolution\n') + self.file.write('\tGlobalSection(ProjectDependencies) = postSolution\n' + '\tEndGlobalSection\n') + self.file.write('\tGlobalSection(ProjectConfiguration) = postSolution\n') for name in confkeys: name = name.capitalize() - self.file.write(' %s.%s.ActiveCfg = %s|Win32\n' - ' %s.%s.Build.0 = %s|Win32\n' %(self.slnguid,name,name,self.slnguid,name,name)) - self.file.write(' EndGlobalSection\n' - ' GlobalSection(ExtensibilityGlobals) = postSolution\n' - ' EndGlobalSection\n' - ' GlobalSection(ExtensibilityAddIns) = postSolution\n' - ' EndGlobalSection\n' + self.file.write('\t\t%s.%s.ActiveCfg = %s|Win32\n' + '\t\t%s.%s.Build.0 = %s|Win32\n' %(self.slnguid,name,name,self.slnguid,name,name)) + self.file.write('\tEndGlobalSection\n' + '\tGlobalSection(ExtensibilityGlobals) = postSolution\n' + '\tEndGlobalSection\n' + '\tGlobalSection(ExtensibilityAddIns) = postSolution\n' + '\tEndGlobalSection\n' 'EndGlobal\n') pdata = pickle.dumps(self.configs,1) pdata = base64.encodestring(pdata) @@ -666,40 +680,43 @@ class _GenerateV7DSW(_DSWGenerator): self.PrintSolution() self.file.close() +V6DSWHeader = """\ +Microsoft Developer Studio Workspace File, Format Version 6.00 +# WARNING: DO NOT EDIT OR DELETE THIS WORKSPACE FILE! + +############################################################################### + +Project: "%(name)s"="%(dspfile)s" - Package Owner=<4> + +Package=<5> +{{{ +}}} + +Package=<4> +{{{ +}}} + +############################################################################### + +Global: + +Package=<5> +{{{ +}}} + +Package=<3> +{{{ +}}} + +############################################################################### +""" + class _GenerateV6DSW(_DSWGenerator): """Generates a Workspace file for MSVS 6.0""" def PrintWorkspace(self): """ writes a DSW file """ - self.file.write('Microsoft Developer Studio Workspace File, Format Version 6.00\n' - '# WARNING: DO NOT EDIT OR DELETE THIS WORKSPACE FILE!\n' - '\n' - '###############################################################################\n' - '\n' - 'Project: "%s"="%s" - Package Owner=<4>\n' - '\n' - 'Package=<5>\n' - '{{{\n' - '}}}\n' - '\n' - 'Package=<4>\n' - '{{{\n' - '}}}\n' - '\n' - '###############################################################################\n' - '\n' - 'Global:\n' - '\n' - 'Package=<5>\n' - '{{{\n' - '}}}\n' - '\n' - 'Package=<3>\n' - '{{{\n' - '}}}\n' - '\n' - '###############################################################################\n'\ - %(self.name,self.dspfile)) + self.file.write(V6DSWHeader % self.__dict__) def Build(self): try: @@ -723,7 +740,7 @@ def GenerateDSP(dspfile, source, env): def GenerateDSW(dswfile, dspfile, source, env): """Generates a Solution/Workspace file based on the version of MSVS that is being used""" - + if env.has_key('MSVS_VERSION') and float(env['MSVS_VERSION']) >= 7.0: g = _GenerateV7DSW(dswfile, dspfile, source, env) g.Build() @@ -759,7 +776,7 @@ def get_default_visualstudio_version(env): env['MSVS_VERSION'] = version env['MSVS']['VERSIONS'] = versions env['MSVS']['VERSION'] = version - + return version def get_visualstudio_versions(): @@ -838,7 +855,7 @@ def get_visualstudio_versions(): L.remove("6.1") except ValueError: pass - + L.sort() L.reverse() @@ -932,7 +949,7 @@ def get_msvs_install_dirs(version = None): if c == 0: c = int(bbl[2]) - int(aal[2]) return c - + versions.sort(versrt) rv['FRAMEWORKVERSIONS'] = versions @@ -1035,7 +1052,7 @@ def GenerateProject(target, source, env): bdsw.write("This is just a placeholder file.\nThe real workspace file is here:\n%s\n" % dswfile.get_abspath()) GenerateDSP(dspfile, source, env) - GenerateDSW(dswfile, dspfile, source, env) + GenerateDSW(dswfile, dspfile, source, env) def projectEmitter(target, source, env): """Sets up the DSP and DSW dependencies for an SConscript file.""" @@ -1069,7 +1086,7 @@ def projectEmitter(target, source, env): env.Precious(dspfile) # dswfile isn't precious -- it can be blown away and rewritten each time. env.SideEffect(dswfile, target[0]) - + return ([target[0],bdswfile], source) projectGeneratorAction = SCons.Action.Action(GenerateProject, None) @@ -1117,7 +1134,7 @@ def exists(env): v = SCons.Tool.msvs.get_visualstudio_versions() except (SCons.Util.RegError, SCons.Errors.InternalError): pass - + if not v: if env.has_key('MSVS_VERSION') and float(env['MSVS_VERSION']) >= 7.0: return env.Detect('devenv') diff --git a/test/Fortran/F77PATH.py b/test/Fortran/F77PATH.py index 2869d27f..4dd8f515 100644 --- a/test/Fortran/F77PATH.py +++ b/test/Fortran/F77PATH.py @@ -39,7 +39,7 @@ args = prog + ' ' + variant_prog + ' ' + subdir_prog test = TestSCons.TestSCons() if not test.detect('_F77G', 'g77'): - test.skip_test('Found no $F77 tool; skipping test.\n') + test.skip_test('Could not find a $F77 tool; skipping test.\n') test.subdir('include', 'subdir', diff --git a/test/Fortran/FORTRANPATH.py b/test/Fortran/FORTRANPATH.py index 618bea8e..20a92d2f 100644 --- a/test/Fortran/FORTRANPATH.py +++ b/test/Fortran/FORTRANPATH.py @@ -39,7 +39,7 @@ args = prog + ' ' + subdir_prog + ' ' + variant_prog test = TestSCons.TestSCons() if not test.detect('_FORTRANG', 'g77'): - test.skip_test('Found no $F77 tool; skipping test.\n') + test.skip_test('Could not find a $F77 tool; skipping test.\n') test.subdir('include', 'subdir', diff --git a/test/PharLap.py b/test/PharLap.py index 96525986..0455cc25 100644 --- a/test/PharLap.py +++ b/test/PharLap.py @@ -36,8 +36,11 @@ test = TestSCons.TestSCons() if sys.platform != 'win32': test.skip_test('PharLap is only available on win32; skipping test.\n') -test.no_result(not test.detect_tool('linkloc')) -test.no_result(not test.detect_tool('386asm')) +if not test.detect_tool('linkloc'): + test.skip_test("Could not find 'linkloc', skipping test.\n") + +if not test.detect_tool('386asm'): + test.skip_test("Could not find '386asm', skipping test.\n") # From the Phar Lap minasm example program... test.write("minasm.asm", r""" diff --git a/test/RANLIB.py b/test/RANLIB.py index cf4ae783..05edf888 100644 --- a/test/RANLIB.py +++ b/test/RANLIB.py @@ -38,7 +38,8 @@ test = TestSCons.TestSCons() ranlib = test.detect('RANLIB', 'ranlib') -test.no_result(not ranlib) +if not ranlib: + test.skip_test("Could not find 'ranlib', skipping test.\n") test.write("wrapper.py", """import os diff --git a/test/RANLIBFLAGS.py b/test/RANLIBFLAGS.py index d6c25a84..377536ce 100644 --- a/test/RANLIBFLAGS.py +++ b/test/RANLIBFLAGS.py @@ -36,7 +36,8 @@ test = TestSCons.TestSCons() ranlib = test.detect('RANLIB', 'ranlib') -test.no_result(not ranlib) +if not ranlib: + test.skip_test("Could not find 'ranlib', skipping test.\n") test.write("wrapper.py", """import os diff --git a/test/RPATH.py b/test/RPATH.py index 844e4075..6ab6eb29 100644 --- a/test/RPATH.py +++ b/test/RPATH.py @@ -31,10 +31,9 @@ _exe = TestSCons._exe test = TestSCons.TestSCons() -if sys.platform == 'cygwin': - test.no_result(1) -elif sys.platform == 'win32': - test.no_result(1) +if sys.platform in ['cygwin', 'win32']: + msg = "Can not test RPATH on '%s', skipping test.\n" % sys.platform + test.skip_test(msg) foo = test.workpath('foo' + _exe) diff --git a/test/mingw.py b/test/mingw.py index d2039b51..ba6add87 100644 --- a/test/mingw.py +++ b/test/mingw.py @@ -43,7 +43,7 @@ if sys.platform != 'win32': msg = "Skipping mingw test on non-Windows platform '%s'\n" % sys.platform test.skip_test(msg) -# This test requires MingW to be installed: +# This test requires MinGW to be installed: test.write('SConstruct',""" from SCons.Tool.mingw import exists import sys @@ -55,7 +55,7 @@ sys.exit(0) test.run() if string.find(test.stdout(), 'mingw exists') == -1: - test.no_result() + test.skip_test("No MinGW on this system, skipping test.\n") test.subdir('header')