From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 13 Aug 2016 08:01:26 +0000 (+0300)
Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=3078d06109cb2a4b26dee468e735e1a64fdb303c;p=notmuch-archives.git

Re: [PATCH v4 02/16] Move crypto.c into libutil
---

diff --git a/8e/b75c9e6d5014ca7b40ecfb6932bb6bf0efdffe b/8e/b75c9e6d5014ca7b40ecfb6932bb6bf0efdffe
new file mode 100644
index 000000000..a286f2920
--- /dev/null
+++ b/8e/b75c9e6d5014ca7b40ecfb6932bb6bf0efdffe
@@ -0,0 +1,95 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id D57636DE3451
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 01:02:04 -0700 (PDT)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.562
+X-Spam-Level: 
+X-Spam-Status: No, score=0.562 tagged_above=-999 required=5 tests=[AWL=-0.090,
+  SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id 2uYiSzlX-Aik for <notmuch@notmuchmail.org>;
+ Sat, 13 Aug 2016 01:01:56 -0700 (PDT)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 4FCE26DE336E
+ for <notmuch@notmuchmail.org>; Sat, 13 Aug 2016 01:01:55 -0700 (PDT)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id 5C19610007F;
+ Sat, 13 Aug 2016 11:01:26 +0300 (EEST)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>,
+ Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
+ Notmuch Mail <notmuch@notmuchmail.org>
+Subject: Re: [PATCH v4 02/16] Move crypto.c into libutil
+In-Reply-To: <874m6qqznr.fsf@maritornes.cs.unb.ca>
+References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net>
+ <1467970047-8013-3-git-send-email-dkg@fifthhorseman.net>
+ <874m6qqznr.fsf@maritornes.cs.unb.ca>
+User-Agent: Notmuch/0.22+61~geeecb9e (https://notmuchmail.org) Emacs/24.5.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 13 Aug 2016 11:01:26 +0300
+Message-ID: <m2shu99jxl.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 13 Aug 2016 08:02:05 -0000
+
+On Fri, Aug 12 2016, David Bremner <david@tethera.net> wrote:
+
+> Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
+>> +++ b/util/crypto.c
+>> @@ -0,0 +1,138 @@
+>
+>> +#include "notmuch.h"
+>
+> It feels wrong to me for a file in util/ to include notmuch.h.  It seems
+> the same situation holds with search-path.h.  There it seems we use
+> notmuch_bool_t (although I'm not convinced that's the right return
+> type). If that's the only reason maybe we should either factor out the
+> definition or just return ints.
+
+util/search-path.c is easy, change to int or bool (and include stdbool.h,
+as parse-time-string.c does)
+
+util/crypto.c is harder. it uses many more \bnotmuch_.* types. perhaps this
+could be moved to lib/ instead ?
+
+
+
+>
+>> +/* Create a PKCS7 context (GMime 2.6) */
+>> +static notmuch_crypto_context_t *
+>> +create_pkcs7_context (notmuch_crypto_t *crypto)
+>> +{
+>> +    notmuch_crypto_context_t *pkcs7ctx;
+>
+> I guess this is leftover, and causes the build failure.
+>
+>> +
+>> +#include "notmuch.h"
+>
+> Same questions notmuch.h here.
+>
+> d
+> _______________________________________________
+> notmuch mailing list
+> notmuch@notmuchmail.org
+> https://notmuchmail.org/mailman/listinfo/notmuch