From: Austin Clements Date: Mon, 10 Jun 2013 02:15:34 +0000 (+2000) Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2f543e83e4ce1ece9d04ebd04adc5dd1fd1c1905;p=notmuch-archives.git Re: [PATCH 2/2] emacs: Fix "no such file or directory" error --- diff --git a/66/9d1fbc8e02bc3609add0ba00da4bc0e43a605d b/66/9d1fbc8e02bc3609add0ba00da4bc0e43a605d new file mode 100644 index 000000000..a12757c1b --- /dev/null +++ b/66/9d1fbc8e02bc3609add0ba00da4bc0e43a605d @@ -0,0 +1,96 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1CE18431FAF + for ; Sun, 9 Jun 2013 19:15:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LUp6ZCVRwzAh for ; + Sun, 9 Jun 2013 19:15:42 -0700 (PDT) +Received: from dmz-mailsec-scanner-2.mit.edu (dmz-mailsec-scanner-2.mit.edu + [18.9.25.13]) + by olra.theworths.org (Postfix) with ESMTP id 155FB431FAE + for ; Sun, 9 Jun 2013 19:15:42 -0700 (PDT) +X-AuditID: 1209190d-b7fa26d000004bab-10-51b536cbec4c +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP + id D7.75.19371.BC635B15; Sun, 9 Jun 2013 22:15:39 -0400 (EDT) +Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id r5A2Fbb7016505; + Sun, 9 Jun 2013 22:15:38 -0400 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r5A2FYPm029938 + (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); + Sun, 9 Jun 2013 22:15:36 -0400 +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80) + (envelope-from ) + id 1Ulrdu-00061y-Ix; Sun, 09 Jun 2013 22:15:34 -0400 +Date: Sun, 9 Jun 2013 22:15:34 -0400 +From: Austin Clements +To: Mark Walters +Subject: Re: [PATCH 2/2] emacs: Fix "no such file or directory" error +Message-ID: <20130610021534.GB22196@mit.edu> +References: <1370753138-15021-1-git-send-email-amdragon@mit.edu> + <1370753138-15021-3-git-send-email-amdragon@mit.edu> + <87hah7od8b.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <87hah7od8b.fsf@qmul.ac.uk> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IR4hTV1j1ttjXQYMpBTovVc3ksrt+cyezA + 5LFz1l12j2erbjEHMEVx2aSk5mSWpRbp2yVwZaw91c5WcJa9YuNvwwbGbrYuRk4OCQETiSXn + +5kgbDGJC/fWA8W5OIQE9jFKTJm2BiwhJLCBUeLBwVyIxCkmib6PK1khnCWMEte7P4JVsQio + SJxZeooZxGYT0JDYtn85I4gtIqAjcfvQAnYQm1lAWuLb72awemEBV4m+M1fBaniBahrnXGCE + GDqVUeL9r4usEAlBiZMzn7BANGtJ3Pj3EqiZA2zQ8n8cIGFOoF3dq/rAykWBbphychvbBEah + WUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGukV5uZoleakrpJkZwUEvy7mB8 + d1DpEKMAB6MSD++DX1sChVgTy4orcw8xSnIwKYny5ptuDRTiS8pPqcxILM6ILyrNSS0+xCjB + wawkwlvQBFTOm5JYWZValA+TkuZgURLnvZJy019IID2xJDU7NbUgtQgmK8PBoSTBuxZkqGBR + anpqRVpmTglCmomDE2Q4D9BwD5Aa3uKCxNzizHSI/ClGRSlx3l0gCQGQREZpHlwvLOm8YhQH + ekWYdwpIFQ8wYcF1vwIazAQ0eIo6yNXFJYkIKakGRt6bGvo3A2+xzHqpKnXO8s/l2Q+qLn0P + dN4Ze001YGJpXlrn//7HzkxHD9Rs0vhzi4WjOVqxM7Xyzbn6jUaOG5Inr7uRJaWtHSWt91La + LuHprJ+3Nl2L3GZZ32jkGjB3kpBClf1pw+uX3s1zmtPO+3LGpCv5i2fedT4ltOqfecFK3xDe + SYu0I5VYijMSDbWYi4oTAdMCsfMVAwAA +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 10 Jun 2013 02:15:50 -0000 + +Quoth Mark Walters on Jun 09 at 10:16 am: +> +> Both of these patches look good to me +1. I was able to reproduce both +> bugs pretty reliably (the first one always unless masked by the second +> one which occurred about half the time). With these patches I cannot +> trigger either. Also all tests pass. +> +> My only tiny concern is I couldn't find any documentation on whether the +> return value of the filter-function matters at all. Austin's original +> fix (via irc) returned t and this returns nil in the failing case (i.e., +> when results-buf is dead). + +Mm, interesting. To be fair, my choice of "t" for the original fix +was completely arbitrary. I think you're right that the Emacs +documentation doesn't have anything to say about the return values of +filter functions. Furthermore, the example filter functions they give +don't have meaningful return values, so I'm pretty sure this is safe. +Also the code that calls the filter discards its result.