From: David Bremner Date: Tue, 25 Mar 2014 02:14:17 +0000 (+2100) Subject: Re: [PATCH 1/3] build: compute subdirectories from the presence of Makefile.local X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2cf8665b8588c687fe11a1be809df6153074538b;p=notmuch-archives.git Re: [PATCH 1/3] build: compute subdirectories from the presence of Makefile.local --- diff --git a/c7/1a8f49c7a582a4bcb73deafdf4db55b953adc0 b/c7/1a8f49c7a582a4bcb73deafdf4db55b953adc0 new file mode 100644 index 000000000..35b79a5ce --- /dev/null +++ b/c7/1a8f49c7a582a4bcb73deafdf4db55b953adc0 @@ -0,0 +1,67 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8C726431FBD + for ; Mon, 24 Mar 2014 19:14:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id TxqV8HIpIHQ3 for ; + Mon, 24 Mar 2014 19:14:23 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 6812F431FB6 + for ; Mon, 24 Mar 2014 19:14:23 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WSGse-0003Nh-H5; Mon, 24 Mar 2014 23:14:20 -0300 +Received: (nullmailer pid 13180 invoked by uid 1000); Tue, 25 Mar 2014 + 02:14:17 -0000 +From: David Bremner +To: notmuch@notmuchmail.org +Subject: Re: [PATCH 1/3] build: compute subdirectories from the presence of + Makefile.local +In-Reply-To: <1395276484-22363-2-git-send-email-david@tethera.net> +References: <1395276484-22363-1-git-send-email-david@tethera.net> + <1395276484-22363-2-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.17+150~g2743557 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Mon, 24 Mar 2014 23:14:17 -0300 +Message-ID: <87d2hbhvnq.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 25 Mar 2014 02:14:30 -0000 + +David Bremner writes: + +> This allows the fragile sed command in configure to be replaced with a somewhat +> less fragile find command. +> -subdirs = compat completion doc emacs lib parse-time-string \ +> - performance-test util test test/test-databases +> +subdirs = $(dir $(shell find . -mindepth 2 -name Makefile.local)) + +I discovered a bug with this idea. There is actually an ordering +dependency for the sub Makefiles; in particular the targets of +test/Makefile.local use variables defined in lib/Makefile.local. I'll +have to think if/how this can be salvaged. + +d