From: W. Trevor King Date: Mon, 27 Jul 2009 11:22:01 +0000 (-0400) Subject: Put bd into read-only mode in becommands/diff.py. X-Git-Tag: 1.0.0~62^2~46^2~9^2~5 X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2cc6145453fd50fb034e7578362159484ab8e6e7;p=be.git Put bd into read-only mode in becommands/diff.py. Otherwise comment comparison reads were triggering notice of the None -> EMPTY transition in comment.extra_strings, which was causing a write to disk. This trigger is probably occuring in Bug and BugDir too. Perhaps I should just remove the trigger... --- diff --git a/becommands/diff.py b/becommands/diff.py index 1ab2135..b0ef907 100644 --- a/becommands/diff.py +++ b/becommands/diff.py @@ -65,6 +65,12 @@ def execute(args, manipulate_encodings=True): else: if revision == None: # get the most recent revision revision = bd.rcs.revision_id(-1) + # move bd into memory-only mode to avoid altering disk version. + bd.load_all_bugs() + for bug in bd: + bug.load_settings() + bug.load_comments() + bd.set_sync_with_disk(False) old_bd = bd.duplicate_bugdir(revision) d = diff.Diff(old_bd, bd) tree = d.report_tree()