From: SZEDER Gábor <szeder@ira.uka.de>
Date: Sun, 10 Oct 2010 21:48:58 +0000 (+0200)
Subject: bisect: check for mandatory argument of 'bisect replay'
X-Git-Tag: v1.7.4-rc0~141^2
X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2c7c3877def8629278f5367a461ef269b0cfaa99;p=git.git

bisect: check for mandatory argument of 'bisect replay'

'git bisect replay' has a mandatory logfile argument, but the current
implementation doesn't check whether the user has specified one.  When
the user omits the logfile argument, this leads to the following
unhelpful error message:

  cannot read  for replaying

So, check for the mandatory argument first, and provide a more
meaningful error message when it is omitted.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/git-bisect.sh b/git-bisect.sh
index 68fcff6db..c21e33c8d 100755
--- a/git-bisect.sh
+++ b/git-bisect.sh
@@ -343,6 +343,7 @@ bisect_clean_state() {
 }
 
 bisect_replay () {
+	test "$#" -eq 1 || die "No logfile given"
 	test -r "$1" || die "cannot read $1 for replaying"
 	bisect_reset
 	while read git bisect command rev