From: Mark Walters Date: Sat, 11 May 2013 20:05:31 +0000 (+0100) Subject: Re: [PATCH v2 0/3] cli: mail-followup-to support X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2bfb2c684d2667219005b9129f7231f33fba39e3;p=notmuch-archives.git Re: [PATCH v2 0/3] cli: mail-followup-to support --- diff --git a/67/48421d41c956cc863a36536d867c555785d1a3 b/67/48421d41c956cc863a36536d867c555785d1a3 new file mode 100644 index 000000000..68f63f64b --- /dev/null +++ b/67/48421d41c956cc863a36536d867c555785d1a3 @@ -0,0 +1,127 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E490E431FBC + for ; Sat, 11 May 2013 13:05:53 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id qo6HqEFQupYo for ; + Sat, 11 May 2013 13:05:48 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 73CF8431FAE + for ; Sat, 11 May 2013 13:05:48 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1UbG2v-0003yT-Mh; Sat, 11 May 2013 21:05:36 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1UbG2v-0007wC-A2; Sat, 11 May 2013 21:05:33 +0100 +From: Mark Walters +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/3] cli: mail-followup-to support +In-Reply-To: +References: +User-Agent: Notmuch/0.14+255~gff3cc55 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 11 May 2013 21:05:31 +0100 +Message-ID: <87y5blcmes.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: f2ac0168d5ed6c1dbb82e0f4dc530a60 (of first 20000 bytes) +X-SpamAssassin-Score: -0.5 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.5 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.5 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 11 May 2013 20:05:54 -0000 + + +Hi + +On Sat, 30 Mar 2013, Jani Nikula wrote: +> This is v2 of [1], rebased against master and with a better commit +> message for patch 1/3. Patch 1/3 is trivial cleanup and IMO could just +> be merged. There was debate on the actual stuff 2/3 and 3/3 [2]. +> +> I don't think adding a --reply-to=list option to notmuch reply is a good +> idea. We should just do the right thing and keep the cli simple. Perhaps +> we should drop the configuration (patch 2/3) altogether, and just +> support mail-followup-to? + +I think I don't like it as a config option: I would prefer it either as +no option or a command line option (or the JSON as you suggest). I think +we currently honour reply-to unconditionally and ignore mail-reply-to: +is that correct? Otherwise I think the patch looks fine. + +> Or, perhaps notmuch reply should return *all* options in json, and let +> the UI decide. Above all, let the UI change the reply style while +> editing the reply. I'd probably like this approach most, more than these +> patches, but I don't have the time to do it. + +I have some preliminary patches to do this: will post shortly. + +Best wishes + +Mark + + +> Here are the patches anyway; perhaps they could be an intermediate step, +> or just a reference for anyone willing to do the above. +> +> +> BR, +> Jani. +> +> +> [1] id:5eaa3acc22ee5513bdce5ab931b7a79ade880e06.1362254104.git.jani@nikula.org +> [2] id:20130303120745.GA4884@hili.localdomain +> +> Jani Nikula (3): +> cli: config: remove unnecessary braces from if blocks +> cli: add reply.honor_followup_to configuration option +> cli: support Mail-Followup-To: in notmuch reply +> +> notmuch-client.h | 7 +++++++ +> notmuch-config.c | 56 ++++++++++++++++++++++++++++++++++++++++++------------ +> notmuch-reply.c | 25 ++++++++++++++++++++++-- +> 3 files changed, 74 insertions(+), 14 deletions(-) +> +> -- +> 1.7.10.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch