From: Mark Walters Date: Thu, 12 Sep 2013 15:45:57 +0000 (+0100) Subject: Re: [PATCH] emacs: show: stop stderr appearing in buffer X-Git-Url: http://git.tremily.us/?a=commitdiff_plain;h=2bd16887cad5d36da081e9933109af2d7228803a;p=notmuch-archives.git Re: [PATCH] emacs: show: stop stderr appearing in buffer --- diff --git a/41/93e70cd24d8750502ea4456808723d8c73efed b/41/93e70cd24d8750502ea4456808723d8c73efed new file mode 100644 index 000000000..e51362f74 --- /dev/null +++ b/41/93e70cd24d8750502ea4456808723d8c73efed @@ -0,0 +1,193 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 54BFA431FAF + for ; Thu, 12 Sep 2013 08:46:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id uHmGw1dnb4Rp for ; + Thu, 12 Sep 2013 08:46:03 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2CFCB431FAE + for ; Thu, 12 Sep 2013 08:46:03 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1VK95i-0003N1-JP; Thu, 12 Sep 2013 16:46:01 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1VK95i-00008j-8g; Thu, 12 Sep 2013 16:45:58 +0100 +From: Mark Walters +To: Tomi Ollila , David Bremner , + notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: show: stop stderr appearing in buffer +In-Reply-To: +References: <1378502198-7980-1-git-send-email-markwalters1009@gmail.com> + <87r4cwojds.fsf@zancas.localnet> <87ppsepeo9.fsf@qmul.ac.uk> + <87ob7yw8a8.fsf@qmul.ac.uk> + +User-Agent: Notmuch/0.16 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Thu, 12 Sep 2013 16:45:57 +0100 +Message-ID: <87a9jivya2.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: d654062aa0fccf184484c15531f8d1d4 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 12 Sep 2013 15:46:11 -0000 + +On Thu, 12 Sep 2013, Tomi Ollila wrote: +> On Thu, Sep 12 2013, Mark Walters wrote: +> +>> On Thu, 12 Sep 2013, Tomi Ollila wrote: +>>> On Thu, Sep 12 2013, Mark Walters wrote: +>>> +>>>> Hi +>>>> +>>>> On Tue, 10 Sep 2013, David Bremner wrote: +>>>>>> Ideally, we would put this output in the notmuch errors buffer but the +>>>>>> handler is called asynchronously so we don't know when the output will +>>>>>> appear. Thus if we put it straight into the errors buffer it could get +>>>>>> interleaved with other errors, otoh we can't easily tell when we +>>>>>> have got all the error output so can't wait until the process is complete. +>>>>> +>>>>> Hi Mark; +>>>>> +>>>>> I think your patch is OK, but would it be much harder to created a named +>>>>> buffer like *notmuch-view-$message-d* ? (using e.g. the code from +>>>>> notmuch-show). I might make debugging easier. +>>>> +>>>> Yes this is easy. There are several possibilities and I am not sure +>>>> which is best (some are clearly bad but are worth mentioning anyway). +>>>> +>>>> 1) have a single buffer for part errors; this would accumulate stuff and +>>>> output seems to get interleaved so this is probably useless. +>>>> +>>>> 2) have a buffer for each part viewer as you describe. +>>>> +>>>> 3) have a buffer for each part viewer but start its name with a space so +>>>> it doesn't show up in buffer lists but is findable (maybe) +>>>> +>>>> 4) stick with just the temp buffer approach +>>> +>>> +>>> Maybe check whether the temp buffer is empty. if not, use +>>> (buffer-string) & (notmuch-logged-error) to append the message +>>> to the *Notmuch errors* buffer... just that notmuch-logged-error +>>> signals an error which we may not want to do... +>> +>> The problem is that the external part viewer is run asynchronously. So +>> when we get to the decision what to do the buffer has not received any +>> output yet even when the first thing the viewer does is output +>> something. +>> +>> A further complication is that in some cases the viewer might not +>> output things until it is closed and that could be arbitrarily later. +> +> I may not have understood completely -- but the temp buffer has lifetime... +> We could store the timestamp when executing function starts and just +> before the temp buffer is about to be wiped out, do the emptiness check +> and if not empty use the stored timestamp & current time in the message +> to be written to aid the human reader who may want to see the message... + +The temp buffer is killed as soon as mm-display-external returns which +is almost instantly as it starts the external viewer asynchronously. The +sentinel for the external viewer (called when the external viewer exits) +sees the calling buffer is dead and just drops the error/output. + +So it is not really that the error goes into the temp buffer: it just +doesn't go into the (quite likely still existing) show buffer. + +Best wishes + +Mark + + + + + +> +>> +>> Best wishes +>> +>> Mark +> +> Tomi +> +> +>> +>> +>>> +>>> We could unify to "*Notmuch Messages*" and have more functions to +>>> append data there... somewhat analogous to current *Messages* buffer +>>> just that that one has so much noise... +>>> +>>> Tomi +>>> +>>> +>>>> +>>>> Also, we could have it togglable with some sort of debug flag. In some +>>>> senses 3 is nice but you would probably end up with 10's or even +>>>> hundreds of hidden buffers which seems bad. In 2 you see them so you +>>>> probably kill them as you go but I think they would be pretty +>>>> annoying. A key difference from the accumulated show/search/pick buffers +>>>> is that, at some point, you did want to see those buffers. +>>>> +>>>> Since all these approaches are easy to implement it is really up to us +>>>> which we want. +>>>> +>>>> Any thoughts? +>>>> +>>>> Mark +>>>> +>>>> +>>>>> +>>>>> Of course those buffers would accumulate, along with show, search and +>>>>> pick buffers... +>>>>> +>>>>> Or we could push this as is, and add some debugging facility later like +>>>>> a variable notmuch-view-errors-buffer. +>>>>> +>>>>> d +>>>> _______________________________________________ +>>>> notmuch mailing list +>>>> notmuch@notmuchmail.org +>>>> http://notmuchmail.org/mailman/listinfo/notmuch +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch